fix: Do not allow same column to be reused in data sources (#2965)

* Do not allow same column to be reused in data sources Signed-off-by: Felix Wang <[email protected]> * Fix bug Signed-off-by: Felix Wang <[email protected]>
feast-dev · Jul 21, 2022 · 661c053 · 661c053
1 parent 5e45228
commit 661c053
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -273,6 +273,13 @@ def __init__(
                 ),
                 DeprecationWarning,
             )
+        if (
+            self.timestamp_field
+            and self.timestamp_field == self.created_timestamp_column
+        ):
+            raise ValueError(
+                "Please do not use the same column for 'timestamp_field' and 'created_timestamp_column'."
+            )
         self.description = description or ""
         self.tags = tags or {}
         self.owner = owner or ""

diff --git a/sdk/python/tests/unit/test_data_sources.py b/sdk/python/tests/unit/test_data_sources.py
@@ -261,3 +261,13 @@ def test_proto_conversion():
     assert DataSource.from_proto(kinesis_source.to_proto()) == kinesis_source
     assert DataSource.from_proto(push_source.to_proto()) == push_source
     assert DataSource.from_proto(request_source.to_proto()) == request_source
+
+
+def test_column_conflict():
+    with pytest.raises(ValueError):
+        _ = FileSource(
+            name="test_source",
+            path="test_path",
+            timestamp_field="event_timestamp",
+            created_timestamp_column="event_timestamp",
+        )