ci: Fix setuptools issue with wildcard (#3471)

* ci: Fix setuptools issue with wildcard Signed-off-by: Danny Chiao <[email protected]> * fix lint Signed-off-by: Danny Chiao <[email protected]> * pin mypy Signed-off-by: Danny Chiao <[email protected]> * fix httpx test Signed-off-by: Danny Chiao <[email protected]> * pin mypy Signed-off-by: Danny Chiao <[email protected]> * fix lint issue Signed-off-by: Danny Chiao <[email protected]> * final fix Signed-off-by: Danny Chiao <[email protected]> --------- Signed-off-by: Danny Chiao <[email protected]>
feast-dev · Jan 30, 2023 · 75829f0 · 75829f0
1 parent dfd5eae
commit 75829f0
Show file tree

Hide file tree

Showing 11 changed files with 546 additions and 444 deletions.
diff --git a/Makefile b/Makefile
@@ -289,7 +289,7 @@ format-python:
 	cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/
 
 	# Format
-	cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests
+	cd ${ROOT_DIR}/sdk/python; python -m black --target-version py38 feast tests
 
 lint-python:
 	cd ${ROOT_DIR}/sdk/python; python -m mypy

diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -2327,7 +2327,7 @@ def serve_ui(
         port: int,
         get_registry_dump: Callable,
         registry_ttl_sec: int,
-        root_path: Optional[str] = "",
+        root_path: str = "",
     ) -> None:
         """Start the UI server locally"""
         if flags_helper.is_test():

diff --git a/sdk/python/feast/infra/materialization/contrib/spark/spark_materialization_engine.py b/sdk/python/feast/infra/materialization/contrib/spark/spark_materialization_engine.py
@@ -1,6 +1,6 @@
 from dataclasses import dataclass
 from datetime import datetime
-from typing import Callable, List, Literal, Optional, Sequence, Union
+from typing import Callable, List, Literal, Optional, Sequence, Union, cast
 
 import dill
 import pandas as pd
@@ -154,7 +154,8 @@ def _materialize_one(
         job_id = f"{feature_view.name}-{start_date}-{end_date}"
 
         try:
-            offline_job: SparkRetrievalJob = (
+            offline_job = cast(
+                SparkRetrievalJob,
                 self.offline_store.pull_latest_from_table_or_query(
                     config=self.repo_config,
                     data_source=feature_view.batch_source,
@@ -164,7 +165,7 @@ def _materialize_one(
                     created_timestamp_column=created_timestamp_column,
                     start_date=start_date,
                     end_date=end_date,
-                )
+                ),
             )
 
             spark_serialized_artifacts = _SparkSerializedArtifacts.serialize(

diff --git a/sdk/python/feast/ui_server.py b/sdk/python/feast/ui_server.py
@@ -101,7 +101,7 @@ def start_server(
     get_registry_dump: Callable,
     project_id: str,
     registry_ttl_sec: int,
-    root_path: Optional[str] = "",
+    root_path: str = "",
 ):
     app = get_app(
         store,