Skip to content

Commit

Permalink
Clarify TODO comment for entity dataframe time ranges
Browse files Browse the repository at this point in the history
Co-authored-by: Oleg Avdeev <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
  • Loading branch information
woop and oavdeev committed Mar 16, 2021
1 parent 2468261 commit 83f173c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/feast/offline_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def get_historical_features(
# Build a query context containing all information required to template the BigQuery SQL query
query_context = get_feature_view_query_context(feature_refs, feature_views)

# TODO: Get timestamps from entity_df
# TODO: Infer min_timestamp and max_timestamp from entity_df
# Generate the BigQuery SQL query from the query context
query = build_point_in_time_query(
query_context,
Expand Down

0 comments on commit 83f173c

Please sign in to comment.