feat: Dropping the support for python 3.8 version from feast (#4010)

* Dropping the support for python 3.8 version from feast Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * updating the pyproject.toml to use the python 3.9 version. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * Dropping the support for python 3.8 but these are required to merge the PR as the PR build needs these files because it runs based on the master files. We will be deleting these files once the PR is merged. Signed-off-by: Lokesh Rangineni <[email protected]> * Adding missed file. dropping the support for python 3.8. Dropping the support for python 3.8 but these are required to merge the PR as the PR build needs these files because it runs based on the master files. We will be deleting these files once the PR is merged. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * Trying to fix the integration test failures with drop python 3.8 version PR. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> --------- Signed-off-by: Lokesh Rangineni <[email protected]>
feast-dev · Mar 18, 2024 · a0f7472 · a0f7472
1 parent be52772
commit a0f7472
Show file tree

Hide file tree

Showing 17 changed files with 77 additions and 55 deletions.
diff --git a/.github/fork_workflows/fork_pr_integration_tests_aws.yml b/.github/fork_workflows/fork_pr_integration_tests_aws.yml
@@ -67,7 +67,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.8" ]
+        python-version: [ "3.9" ]
         os: [ ubuntu-latest ]
     env:
       OS: ${{ matrix.os }}

diff --git a/.github/fork_workflows/fork_pr_integration_tests_gcp.yml b/.github/fork_workflows/fork_pr_integration_tests_gcp.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.8" ]
+        python-version: [ "3.9" ]
         os: [ ubuntu-latest ]
     env:
       OS: ${{ matrix.os }}

diff --git a/.github/fork_workflows/fork_pr_integration_tests_snowflake.yml b/.github/fork_workflows/fork_pr_integration_tests_snowflake.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.8" ]
+        python-version: [ "3.9" ]
         os: [ ubuntu-latest ]
     env:
       OS: ${{ matrix.os }}

diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
@@ -59,7 +59,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.8"
+          python-version: "3.9"
           architecture: x64
       - name: Setup Node
         uses: actions/setup-node@v3
@@ -137,7 +137,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest,  macos-latest ]
-        python-version: [ "3.8", "3.9", "3.10"]
+        python-version: ["3.9", "3.10"]
         from-source: [ True, False ]
     env:
       # this script is for testing servers

diff --git a/.github/workflows/java_master_only.yml b/.github/workflows/java_master_only.yml
@@ -25,7 +25,7 @@ jobs:
         uses: actions/setup-python@v3
         id: setup-python
         with:
-          python-version: "3.8"
+          python-version: "3.9"
           architecture: x64
       - name: Authenticate to Google Cloud
         uses: 'google-github-actions/auth@v1'
@@ -95,7 +95,7 @@ jobs:
     if: github.repository == 'feast-dev/feast'
     runs-on: ubuntu-latest
     env:
-      PYTHON: 3.8
+      PYTHON: 3.9
     steps:
       - uses: actions/checkout@v3
         with:
@@ -110,7 +110,7 @@ jobs:
         uses: actions/setup-python@v3
         id: setup-python
         with:
-          python-version: 3.8
+          python-version: 3.9
           architecture: x64
       - name: Get pip cache dir
         id: pip-cache

diff --git a/.github/workflows/java_pr.yml b/.github/workflows/java_pr.yml
@@ -88,7 +88,7 @@ jobs:
         uses: actions/setup-python@v3
         id: setup-python
         with:
-          python-version: "3.8"
+          python-version: "3.9"
           architecture: x64
       - name: Authenticate to Google Cloud
         uses: 'google-github-actions/auth@v1'
@@ -111,7 +111,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: unit-test-java
     env:
-      PYTHON: 3.8
+      PYTHON: 3.9
     steps:
       - uses: actions/checkout@v3
         with:
@@ -128,7 +128,7 @@ jobs:
           architecture: x64
       - uses: actions/setup-python@v3
         with:
-          python-version: '3.8'
+          python-version: '3.9'
           architecture: 'x64'
       - uses: actions/cache@v2
         with:
@@ -158,7 +158,7 @@ jobs:
         uses: actions/setup-python@v3
         id: setup-python
         with:
-          python-version: 3.8
+          python-version: 3.9
           architecture: x64
       - name: Get pip cache dir
         id: pip-cache

diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -6,14 +6,14 @@ jobs:
   lint-python:
     runs-on: [ubuntu-latest]
     env:
-      PYTHON: 3.8
+      PYTHON: 3.9
     steps:
       - uses: actions/checkout@v3
       - name: Setup Python
         id: setup-python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.8"
+          python-version: "3.9"
           architecture: x64
       - name: Get pip cache dir
         id: pip-cache

diff --git a/.github/workflows/master_only.yml b/.github/workflows/master_only.yml
@@ -65,7 +65,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.8", "3.9", "3.10" ]
+        python-version: ["3.9", "3.10" ]
         os: [ ubuntu-latest ]
     env:
       OS: ${{ matrix.os }}

diff --git a/.github/workflows/nightly-ci.yml b/.github/workflows/nightly-ci.yml
@@ -36,7 +36,7 @@ jobs:
         uses: actions/setup-python@v3
         id: setup-python
         with:
-          python-version: "3.8"
+          python-version: "3.9"
           architecture: x64
       - name: Set up AWS SDK
         uses: aws-actions/configure-aws-credentials@v1
@@ -124,7 +124,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.8" ]
+        python-version: [ "3.9" ]
         os: [ ubuntu-latest ]
     env:
       OS: ${{ matrix.os }}

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -160,7 +160,7 @@ jobs:
           architecture: x64
       - uses: actions/setup-python@v3
         with:
-          python-version: '3.7'
+          python-version: '3.9'
           architecture: 'x64'
       - uses: actions/cache@v2
         with:

diff --git a/environment-setup.md b/environment-setup.md
@@ -0,0 +1,23 @@
+1. install anaconda, install docker
+2. create an environment for feast, selecting python 3.9. Activate the environment:
+```bash
+conda create --name feast python=3.9
+conda activate feast
+```
+3. install dependencies:
+```bash
+pip install pip-tools
+brew install mysql
+brew install xz protobuf openssl zlib
+pip install cryptography -U
+conda install protobuf
+conda install pymssql
+pip install -e ".[dev]"
+make install-protoc-dependencies PYTHON=3.9
+make install-python-ci-dependencies PYTHON=3.9
+```
+4. start the docker daemon
+5. run unit tests:
+```bash
+make test-python
+```
diff --git a/java/serving/src/test/resources/docker-compose/feast10/Dockerfile b/java/serving/src/test/resources/docker-compose/feast10/Dockerfile
@@ -1,4 +1,4 @@
-FROM python:3.8
+FROM python:3.9
 
 WORKDIR /usr/src/
 

diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
@@ -1,4 +1,4 @@
-FROM python:3.8
+FROM python:3.9
 
 # Input the feast version to install
 # This requires feast package to be available in pypi before building this image

diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM python:3.8
+FROM python:3.9
 
 # Input the feast version to install
 # This requires feast package to be available in pypi before building this image

diff --git a/sdk/python/feast/infra/utils/snowflake/snowpark/snowflake_python_udfs_creation.sql b/sdk/python/feast/infra/utils/snowflake/snowpark/snowflake_python_udfs_creation.sql
@@ -1,127 +1,127 @@
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_binary_to_bytes_proto(df BINARY)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_binary_to_bytes_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_varchar_to_string_proto(df VARCHAR)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_varchar_to_string_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_bytes_to_list_bytes_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_bytes_to_list_bytes_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_varchar_to_list_string_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_varchar_to_list_string_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_number_to_list_int32_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_number_to_list_int32_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_number_to_list_int64_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_number_to_list_int64_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_float_to_list_double_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_float_to_list_double_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_boolean_to_list_bool_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_boolean_to_list_bool_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_array_timestamp_to_list_unix_timestamp_proto(df ARRAY)
     RETURNS BINARY
     LANGUAGE PYTHON
-    RUNTIME_VERSION = '3.8'
+    RUNTIME_VERSION = '3.9'
     PACKAGES = ('protobuf', 'pandas')
     HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_array_timestamp_to_list_unix_timestamp_proto'
     IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_number_to_int32_proto(df NUMBER)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_number_to_int32_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_number_to_int64_proto(df NUMBER)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_number_to_int64_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_float_to_double_proto(df DOUBLE)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_float_to_double_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_boolean_to_bool_proto(df BOOLEAN)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_boolean_to_bool_boolean_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_snowflake_timestamp_to_unix_timestamp_proto(df NUMBER)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_snowflake_timestamp_to_unix_timestamp_proto'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_serialize_entity_keys(names ARRAY, data ARRAY, types ARRAY)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_serialize_entity_keys'
   IMPORTS = ('@STAGE_HOLDER/feast.zip');
 
 CREATE FUNCTION IF NOT EXISTS feast_PROJECT_NAME_entity_key_proto_to_string(names ARRAY, data ARRAY, types ARRAY)
   RETURNS BINARY
   LANGUAGE PYTHON
-  RUNTIME_VERSION = '3.8'
+  RUNTIME_VERSION = '3.9'
   PACKAGES = ('protobuf', 'pandas')
   HANDLER = 'feast.infra.utils.snowflake.snowpark.snowflake_udfs.feast_entity_key_proto_to_string'
   IMPORTS = ('@STAGE_HOLDER/feast.zip')