Rename to_table to to_arrow (#1671)

Signed-off-by: Matt Delacour <[email protected]>
feast-dev · Jun 29, 2021 · d0ae38f · d0ae38f
1 parent 5a49470
commit d0ae38f
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 10 deletions.
diff --git a/sdk/python/feast/infra/gcp.py b/sdk/python/feast/infra/gcp.py
@@ -110,7 +110,7 @@ def materialize_single_feature_view(
             start_date=start_date,
             end_date=end_date,
         )
-        table = offline_job.to_table()
+        table = offline_job.to_arrow()
 
         if feature_view.input.field_mapping is not None:
             table = _run_field_mapping(table, feature_view.input.field_mapping)

diff --git a/sdk/python/feast/infra/local.py b/sdk/python/feast/infra/local.py
@@ -109,7 +109,7 @@ def materialize_single_feature_view(
             end_date=end_date,
             config=config,
         )
-        table = offline_job.to_table()
+        table = offline_job.to_arrow()
 
         if feature_view.input.field_mapping is not None:
             table = _run_field_mapping(table, feature_view.input.field_mapping)

diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -275,7 +275,7 @@ def _block_until_done():
         print(f"Done writing to '{job_config.destination}'.")
         return str(job_config.destination)
 
-    def to_table(self) -> pyarrow.Table:
+    def to_arrow(self) -> pyarrow.Table:
         return self.client.query(self.query).to_arrow()
 
 

diff --git a/sdk/python/feast/infra/offline_stores/file.py b/sdk/python/feast/infra/offline_stores/file.py
@@ -38,7 +38,7 @@ def to_df(self):
         df = self.evaluation_function()
         return df
 
-    def to_table(self):
+    def to_arrow(self):
         # Only execute the evaluation function to build the final historical retrieval dataframe at the last moment.
         df = self.evaluation_function()
         return pyarrow.Table.from_pandas(df)

diff --git a/sdk/python/feast/infra/offline_stores/offline_store.py b/sdk/python/feast/infra/offline_stores/offline_store.py
@@ -33,7 +33,7 @@ def to_df(self) -> pd.DataFrame:
         pass
 
     @abstractmethod
-    def to_table(self) -> pyarrow.Table:
+    def to_arrow(self) -> pyarrow.Table:
         """Return dataset as pyarrow Table synchronously"""
         pass
 

diff --git a/sdk/python/tensorflow_metadata/proto/v0/path_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/path_pb2.py
diff --git a/sdk/python/tensorflow_metadata/proto/v0/schema_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/schema_pb2.py
diff --git a/sdk/python/tensorflow_metadata/proto/v0/statistics_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/statistics_pb2.py
diff --git a/sdk/python/tests/test_historical_retrieval.py b/sdk/python/tests/test_historical_retrieval.py
@@ -461,7 +461,7 @@ def test_historical_features_from_bigquery_sources(
             check_dtype=False,
         )
 
-        table_from_sql_entities = job_from_sql.to_table()
+        table_from_sql_entities = job_from_sql.to_arrow()
         assert_frame_equal(
             actual_df_from_sql_entities, table_from_sql_entities.to_pandas()
         )
@@ -546,7 +546,7 @@ def test_historical_features_from_bigquery_sources(
             .reset_index(drop=True),
             check_dtype=False,
         )
-        table_from_df_entities = job_from_df.to_table()
+        table_from_df_entities = job_from_df.to_arrow()
         assert_frame_equal(
             actual_df_from_df_entities, table_from_df_entities.to_pandas()
         )