Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-server-java 0.17.0 not work #2195

Closed
hsz1273327 opened this issue Jan 6, 2022 · 4 comments
Closed

feature-server-java 0.17.0 not work #2195

hsz1273327 opened this issue Jan 6, 2022 · 4 comments
Assignees

Comments

@hsz1273327
Copy link

Specifications

  • Version: 0.17.0
  • Platform: docker

here is the compose:

...
services:
  ...
  feature-grpc:
    command:
      - java
      - -Xms1g
      - -Xmx4g
      - -jar
      - /opt/feast/feast-serving.jar
      - /etc/feast/application.yml
    configs:
    - source: feast_serve_conf
      target: /etc/feast/application.yml
    deploy:
      replicas: 3
      resources:
        limits:
          cpus: '1.0'
          memory: 500M
      restart_policy:
        condition: on-failure
        delay: 5s
        max_attempts: 3
        window: 100s

...

here is the log:

Exception in thread "main" com.google.inject.ConfigurationException: Guice configuration errors:


1) [Guice/MissingImplementation]: No implementation for Server was bound.


Learn more:

  https://github.com/google/guice/wiki/MISSING_IMPLEMENTATION


1 error


======================

Full classname legend:

======================

Server: "io.grpc.Server"

========================

End of classname legend:

========================


	at com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1126)

	at com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1086)

	at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1138)

and please write a document for the image feastdev/feature-server-java. Or if feature-server-java is not ready,please show it in the project's readme, set it as a preview feature first.
截屏2022-01-06 上午11 30 03

@adchia
Copy link
Collaborator

adchia commented Jan 6, 2022

Thanks for the issue! The issue you're seeing looks like it might be a regression that was introduced in 0.17 after a PR that removed spring boot in favor of Guice. There def is a module providing that though (https://github.com/feast-dev/feast/blob/master/java/serving/src/main/java/feast/serving/config/ServerModule.java#L41-L41) so hopefully should be a quick fix cc @achals

Writing a document on using the java feature server is something we want to get done in the next 2 weeks, so stay tuned for that!

@pyalex
Copy link
Collaborator

pyalex commented Jan 6, 2022

Hi @hsz1273327! Unfortunately, this issue slipped into the release, but it was already fixed in master. You can use dev image available here gcr.io/kf-feast/feature-server-java:develop

@pyalex pyalex closed this as completed Jan 6, 2022
@pyalex
Copy link
Collaborator

pyalex commented Jan 6, 2022

For reference: #2187

@hsz1273327
Copy link
Author

thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants