Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple application properties files (incl from classpath) #2187

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jan 4, 2022

Signed-off-by: pyalex [email protected]

What this PR does / why we need it:

After the recent deletion of Spring in Java feature server we have some functionality degradation:

  • Multiple configuration files are not supported
  • Default configuration (stored in classpath) cannot be loaded

Also ApplicationProperties$Store class cannot be deserialized (bug) due to the absense of the default constructor.

This PR addresses all those issues and returns back the possibility to override configurations.
Also helm chart and docker-compose were updated to new expected CMD format.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: pyalex <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 94c780b into feast-dev:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants