feat: Make feast PEP 561 compliant #2405

tpvasconcelos · 2022-03-14T21:29:48Z

Feast is not PEP 561 compliant which means that mypy won't infer types from feast even though the library is fully typed. This can easily be fixed by including a py.typed marker file at the root of the package.

References:

Signed-off-by: Tomas Pereira de Vasconcelos [email protected]

codecov-commenter · 2022-03-14T21:32:54Z

Codecov Report

Merging #2405 (90a3d76) into master (e14369d) will not change coverage.
The diff coverage is n/a.

❗ Current head 90a3d76 differs from pull request most recent head 6c36f69. Consider uploading reports for the commit 6c36f69 to get more accurate results

@@           Coverage Diff           @@
##           master    #2405   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         122      122           
  Lines       10704    10704           
=======================================
  Hits         8930     8930           
  Misses       1774     1774

Flag	Coverage Δ
integrationtests	`73.16% <ø> (-0.26%)`	⬇️
unittests	`57.12% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14369d...6c36f69. Read the comment docs.

Makefile

achals · 2022-03-15T05:36:31Z

Thanks @tpvasconcelos! Can you add your sign-off to the commit and force push your branch? that should make the DCO check happy.

sdk/python/setup.cfg

woop · 2022-03-15T12:04:55Z

/ok-to-test

woop · 2022-03-15T12:05:41Z

Thanks for the PR btw @tpvasconcelos!

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex <[email protected]> * fix tests Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…sisten… (feast-dev#2418) * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex <[email protected]> * fix local e2e test Signed-off-by: pyalex <[email protected]> * reuse timestamp in response generation Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…ting CONTRIBUTING.md (feast-dev#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…t-dev#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…east-dev#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang <[email protected]> * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang <[email protected]> * Change examples to stop using Duration Signed-off-by: Felix Wang <[email protected]> * Delete unused example feature repo Signed-off-by: Felix Wang <[email protected]> * Format Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…es (feast-dev#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex <[email protected]> * fix tests Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…sisten… (feast-dev#2418) * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex <[email protected]> * fix local e2e test Signed-off-by: pyalex <[email protected]> * reuse timestamp in response generation Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…ting CONTRIBUTING.md (feast-dev#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…t-dev#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…east-dev#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang <[email protected]> * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang <[email protected]> * Change examples to stop using Duration Signed-off-by: Felix Wang <[email protected]> * Delete unused example feature repo Signed-off-by: Felix Wang <[email protected]> * Format Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

…es (feast-dev#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

tpvasconcelos · 2022-03-22T18:57:41Z

@woop @achals I think this is ready to merge. Can you take a look?

achals

/lgtm

feast-ci-bot · 2022-03-22T19:03:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tpvasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

achals · 2022-03-22T19:03:56Z

@woop @achals I think this is ready to merge. Can you take a look?

Just approved. Thanks for the contribution and your patience as we worked through some of these issues!

# [0.20.0](v0.19.0...v0.20.0) (2022-04-14) ### Bug Fixes * Add inlined data sources to the top level registry ([#2456](#2456)) ([356788a](356788a)) * Add new value types to types.ts for web ui ([#2463](#2463)) ([ad5694e](ad5694e)) * Add PushSource proto and Python class ([#2428](#2428)) ([9a4bd63](9a4bd63)) * Add spark to lambda dockerfile ([#2480](#2480)) ([514666f](514666f)) * Added private_key auth for Snowflake ([#2508](#2508)) ([c42c9b0](c42c9b0)) * Added Redshift and Spark typecheck to data_source event_timestamp_col inference ([#2389](#2389)) ([04dea73](04dea73)) * Building of go extension fails ([#2448](#2448)) ([7d1efd5](7d1efd5)) * Bump the number of versions bumps expected to 27 ([#2549](#2549)) ([ecc9938](ecc9938)) * Create __init__ files for the proto-generated python dirs ([#2410](#2410)) ([e17028d](e17028d)) * Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. ([#2415](#2415)) ([b95f441](b95f441)) * Dynamodb deduplicate batch write request by partition keys ([#2515](#2515)) ([70d4a13](70d4a13)) * Ensure that __init__ files exist in proto dirs ([#2433](#2433)) ([9b94f7b](9b94f7b)) * Fix DataSource constructor to unbreak custom data sources ([#2492](#2492)) ([712653e](712653e)) * Fix default feast apply path without any extras ([#2373](#2373)) ([6ba7fc7](6ba7fc7)) * Fix definitions.py with new definition ([#2541](#2541)) ([eefc34a](eefc34a)) * Fix entity row to use join key instead of name ([#2521](#2521)) ([c22fa2c](c22fa2c)) * Fix Java Master ([#2499](#2499)) ([e083458](e083458)) * Fix registry proto ([#2435](#2435)) ([ea6a9b2](ea6a9b2)) * Fix some inconsistencies in the docs and comments in the code ([#2444](#2444)) ([ad008bf](ad008bf)) * Fix spark docs ([#2382](#2382)) ([d4a606a](d4a606a)) * Fix Spark template to work correctly on feast init -t spark ([#2393](#2393)) ([ae133fd](ae133fd)) * Fix the feature repo fixture used by java tests ([#2469](#2469)) ([32e925e](32e925e)) * Fix unhashable Snowflake and Redshift sources ([cd8f1c9](cd8f1c9)) * Fixed bug in passing config file params to snowflake python connector ([#2503](#2503)) ([34f2b59](34f2b59)) * Fixing Spark template to include source name ([#2381](#2381)) ([a985f1d](a985f1d)) * Make name a keyword arg for the Entity class ([#2467](#2467)) ([43847de](43847de)) * Making a name for data sources not a breaking change ([#2379](#2379)) ([71d7ae2](71d7ae2)) * Minor link fix in `CONTRIBUTING.md` ([#2481](#2481)) ([2917e27](2917e27)) * Preserve ordering of features in _get_column_names ([#2457](#2457)) ([495b435](495b435)) * Relax click python requirement to >=7 ([#2450](#2450)) ([f202f92](f202f92)) * Remove date partition column field from datasources that don't s… ([#2478](#2478)) ([ce35835](ce35835)) * Remove docker step from unit test workflow ([#2535](#2535)) ([6f22f22](6f22f22)) * Remove spark from the AWS Lambda dockerfile ([#2498](#2498)) ([6abae16](6abae16)) * Request data api update ([#2488](#2488)) ([0c9e5b7](0c9e5b7)) * Schema update ([#2509](#2509)) ([cf7bbc2](cf7bbc2)) * Simplify DataSource.from_proto logic ([#2424](#2424)) ([6bda4d2](6bda4d2)) * Snowflake api update ([#2487](#2487)) ([1181a9e](1181a9e)) * Support passing batch source to streaming sources for backfills ([#2523](#2523)) ([90db1d1](90db1d1)) * Timestamp update ([#2486](#2486)) ([bf23111](bf23111)) * Typos in Feast UI error message ([#2432](#2432)) ([e14369d](e14369d)) * Update feature view APIs to prefer keyword args ([#2472](#2472)) ([7c19cf7](7c19cf7)) * Update file api ([#2470](#2470)) ([83a11c6](83a11c6)) * Update Makefile to cd into python dir before running commands ([#2437](#2437)) ([ca32155](ca32155)) * Update redshift api ([#2479](#2479)) ([4fa73a9](4fa73a9)) * Update some fields optional in UI parser ([#2380](#2380)) ([cff7ac3](cff7ac3)) * Use a single version of jackson libraries and upgrade to 2.12.6.1 ([#2473](#2473)) ([5be1cc6](5be1cc6)) * Use dateutil parser to parse materialization times ([#2464](#2464)) ([6c55e49](6c55e49)) * Use the correct dockerhub image tag when building feature servers ([#2372](#2372)) ([0d62c1d](0d62c1d)) ### Features * Add `/write-to-online-store` method to the python feature server ([#2423](#2423)) ([d2fb048](d2fb048)) * Add description, tags, owner fields to all feature view classes ([#2440](#2440)) ([ed5e928](ed5e928)) * Add DQM Logging on GRPC Server with FileLogStorage for Testing ([#2403](#2403)) ([57a97d8](57a97d8)) * Add Feast types in preparation for changing type system ([#2475](#2475)) ([4864252](4864252)) * Add Field class ([#2500](#2500)) ([1279612](1279612)) * Add support for DynamoDB online_read in batches ([#2371](#2371)) ([702ec49](702ec49)) * Add Support for DynamodbOnlineStoreConfig endpoint_url parameter ([#2485](#2485)) ([7b863d1](7b863d1)) * Add templating for dynamodb table name ([#2394](#2394)) ([f591088](f591088)) * Allow local feature server to use Go feature server if enabled ([#2538](#2538)) ([a2ef375](a2ef375)) * Allow using entity's join_key in get_online_features ([#2420](#2420)) ([068c765](068c765)) * Data Source Api Update ([#2468](#2468)) ([6b96b21](6b96b21)) * Go server ([#2339](#2339)) ([d12e7ef](d12e7ef)), closes [#2354](#2354) [#2361](#2361) [#2332](#2332) [#2356](#2356) [#2363](#2363) [#2349](#2349) [#2355](#2355) [#2336](#2336) [#2361](#2361) [#2363](#2363) [#2344](#2344) [#2354](#2354) [#2347](#2347) [#2350](#2350) [#2356](#2356) [#2355](#2355) [#2349](#2349) [#2352](#2352) [#2341](#2341) [#2336](#2336) [#2373](#2373) [#2315](#2315) [#2372](#2372) [#2332](#2332) [#2349](#2349) [#2336](#2336) [#2361](#2361) [#2363](#2363) [#2344](#2344) [#2354](#2354) [#2347](#2347) [#2350](#2350) [#2356](#2356) [#2355](#2355) [#2349](#2349) [#2352](#2352) [#2341](#2341) [#2336](#2336) [#2373](#2373) [#2379](#2379) [#2380](#2380) [#2382](#2382) [#2364](#2364) [#2366](#2366) [#2386](#2386) * Graduate write_to_online_store out of experimental status ([#2426](#2426)) ([e7dd4b7](e7dd4b7)) * Make feast PEP 561 compliant ([#2405](#2405)) ([3c41f94](3c41f94)), closes [#2420](#2420) [#2418](#2418) [#2425](#2425) [#2426](#2426) [#2427](#2427) [#2431](#2431) [#2433](#2433) [#2420](#2420) [#2418](#2418) [#2425](#2425) [#2426](#2426) [#2427](#2427) [#2431](#2431) [#2433](#2433) * Makefile for contrib for Issue [#2364](#2364) ([#2366](#2366)) ([a02325b](a02325b)) * Support on demand feature views in go feature server ([#2494](#2494)) ([6edd274](6edd274)) * Switch from Feature to Field ([#2514](#2514)) ([6a03bed](6a03bed)) * Use a daemon thread to monitor the go feature server exclusively ([#2391](#2391)) ([0bb5e8c](0bb5e8c))

tpvasconcelos requested a review from a team as a code owner March 14, 2022 21:29

tpvasconcelos requested review from MattDelac and removed request for a team March 14, 2022 21:29

github-actions bot assigned woop Mar 14, 2022

feast-ci-bot added the size/XS label Mar 14, 2022

tpvasconcelos changed the title ~~Add py.typed marker~~ feat: make feast PEP 561 compliant Mar 14, 2022

tpvasconcelos changed the title ~~feat: make feast PEP 561 compliant~~ feat: Make feast PEP 561 compliant Mar 14, 2022

tpvasconcelos commented Mar 14, 2022

View reviewed changes

Makefile Show resolved Hide resolved

woop reviewed Mar 15, 2022

View reviewed changes

sdk/python/setup.cfg Outdated Show resolved Hide resolved

feast-ci-bot added the ok-to-test label Mar 15, 2022

achals mentioned this pull request Mar 15, 2022

fix: Create __init__ files for the proto-generated python dirs #2410

Merged

feast-ci-bot added size/S and removed size/XS labels Mar 22, 2022

achals mentioned this pull request Mar 22, 2022

fix: Ensure that __init__ files exist in proto dirs #2433

Merged

feast-ci-bot added size/XS and removed size/S labels Mar 22, 2022

tpvasconcelos force-pushed the add-pytyped-marker branch from d9be67b to 4d64b80 Compare March 22, 2022 18:34

feast-ci-bot added size/XL and removed size/XS labels Mar 22, 2022

tpvasconcelos force-pushed the add-pytyped-marker branch from 4d64b80 to 1abaa99 Compare March 22, 2022 18:41

feast-ci-bot added size/XS and removed size/XL labels Mar 22, 2022

tpvasconcelos force-pushed the add-pytyped-marker branch from 1abaa99 to 90a3d76 Compare March 22, 2022 18:43

tpvasconcelos added 3 commits March 22, 2022 19:45

add py.typed marker

ab245e9

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

add py.typed to MANIFEST.in

e1578db

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

ignore mypy error from generated protos modules

e99e8b5

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

achals and others added 17 commits March 22, 2022 19:45

reorder imports

64de086

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

sort imports

29d5272

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

sort imports

e47a32b

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

feat: Graduate write_to_online_store out of experimental status (feas…

b6d6afc

…t-dev#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

ci: Modify release script to only do minor release for breaking chang…

2bfc6bb

…es (feast-dev#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

fix: Ensure that __init__ files exist in proto dirs (feast-dev#2433)

022cca1

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

feat: Graduate write_to_online_store out of experimental status (feas…

8be62c9

…t-dev#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

ci: Modify release script to only do minor release for breaking chang…

849c1cb

…es (feast-dev#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

fix: Ensure that __init__ files exist in proto dirs (feast-dev#2433)

6c36f69

Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>

tpvasconcelos force-pushed the add-pytyped-marker branch from 90a3d76 to 6c36f69 Compare March 22, 2022 18:46

achals approved these changes Mar 22, 2022

View reviewed changes

feast-ci-bot assigned achals Mar 22, 2022

feast-ci-bot added the lgtm label Mar 22, 2022

feast-ci-bot added the approved label Mar 22, 2022

feast-ci-bot merged commit 3c41f94 into feast-dev:master Mar 22, 2022

achals mentioned this pull request Apr 29, 2022

Add PEP-561 compliant stub package #1884

Closed

tpvasconcelos deleted the add-pytyped-marker branch October 7, 2024 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make feast PEP 561 compliant #2405

feat: Make feast PEP 561 compliant #2405

tpvasconcelos commented Mar 14, 2022

codecov-commenter commented Mar 14, 2022 •

edited

Loading

achals commented Mar 15, 2022

woop commented Mar 15, 2022

woop commented Mar 15, 2022

tpvasconcelos commented Mar 22, 2022

achals left a comment

feast-ci-bot commented Mar 22, 2022

achals commented Mar 22, 2022

feat: Make feast PEP 561 compliant #2405

feat: Make feast PEP 561 compliant #2405

Conversation

tpvasconcelos commented Mar 14, 2022

codecov-commenter commented Mar 14, 2022 • edited Loading

Codecov Report

achals commented Mar 15, 2022

woop commented Mar 15, 2022

woop commented Mar 15, 2022

tpvasconcelos commented Mar 22, 2022

achals left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Mar 22, 2022

achals commented Mar 22, 2022

codecov-commenter commented Mar 14, 2022 •

edited

Loading