Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Go server #2339

Merged
merged 181 commits into from
Mar 8, 2022
Merged

feat: Go server #2339

merged 181 commits into from
Mar 8, 2022

Conversation

ctkhanhly
Copy link
Collaborator

@ctkhanhly ctkhanhly commented Feb 24, 2022 •
edited
Loading

What this PR does / why we need it:

This PR adds a go server as a subprocess in the feature store so that on get_online_features() call, features are served via the go subprocess instead of the python server. The go subprocess will be spun up on the first time get_online_features() is called from the python program and will start serving from there. Currently, feast serve and ODFVs are not supported by the go server. Eventually, the hope is that go server will serve features faster than python server.

As for future work, we have a working code for feast serve and a python plugin connector and are working on some benchmarkings to add goroutines and replace some current functions with more optimized implementations to potentially speed up the go server, but we're open to suggestions on but not limited to coding styles, bugs, and potential optimizations.

A few things to mention regarding to the latency when starting go server:

  • The current implementation tries to connect to go server 5 seconds and stops to establish a go server, but I've noticed that sometimes it needs more time to start. This is problematic if we want to automate tests with go server since sometimes go server cannot be started and throw a connection exception and tests fail while it might work properly. I'm open to suggestions on how to make this implementation more robust as well as discussions around trade-off between latency and robustness.
  • This latency needs to increase once the python plugin connector is added since local experiments show that it can take up to 8 seconds.

Does this PR introduce a user-facing change?:

user can add go_feature_server attribute in their feature_store.yaml configuration file to enable using go server on get_online_features()

@ctkhanhly ctkhanhly added the kind/feature New feature or request label Feb 24, 2022
@ctkhanhly ctkhanhly requested a review from a team as a code owner February 24, 2022 23:27
@ctkhanhly ctkhanhly requested review from mavysavydav and removed request for a team February 24, 2022 23:27
@feast-ci-bot
Copy link
Collaborator

@ctkhanhly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@felixwang9817 felixwang9817 changed the title Go server [WIP] feat: Go server Feb 24, 2022
@felixwang9817 felixwang9817 requested review from adchia, tsotnet and woop and removed request for mavysavydav February 24, 2022 23:31
@felixwang9817 felixwang9817 changed the title [WIP] feat: Go server feat: Go server [WIP] Feb 24, 2022
@feast-ci-bot
Copy link
Collaborator

@ctkhanhly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

woop
woop reviewed Feb 25, 2022
View reviewed changes
Makefile Show resolved Hide resolved
woop
woop reviewed Feb 25, 2022
View reviewed changes
Makefile Outdated

lint-go:
cd ${ROOT_DIR}/sdk/go; go vet
go vet ./go/feast ./go/server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a note so that we don't forget: Need to add lint-go to pre-commit hook

Copy link
Collaborator

@felixwang9817 felixwang9817 Feb 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we're not using gofmt here?

edit: never mind, I see we use it in format-go

woop
woop reviewed Feb 25, 2022
View reviewed changes
go/server/server.go Outdated Show resolved Hide resolved
woop
woop reviewed Feb 25, 2022
View reviewed changes
go/feast/basefeatureview.go Outdated Show resolved Hide resolved
woop
woop reviewed Feb 25, 2022
View reviewed changes
go/feast/registry.go Outdated Show resolved Hide resolved
woop
woop reviewed Feb 25, 2022
View reviewed changes
go/feast/repoconfig.go Outdated Show resolved Hide resolved
adchia and others added 6 commits March 8, 2022 12:16
@adchia @achals
fix: Making a name for data sources not a breaking change (feast-dev#…
b54c31a 
…2379)

* fix: Making a name for data sources not a breaking change

Signed-off-by: Danny Chiao <[email protected]>

* fix test

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@mickey-liu @adchia @achals
fix: Update some fields optional in UI parser (feast-dev#2380)
d7710c0 
Signed-off-by: Yun Nan Liu <[email protected]>

Co-authored-by: Yun Nan Liu <[email protected]>
Co-authored-by: Danny Chiao <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@kevjumba @adchia @achals
fix: Fix spark docs (feast-dev#2382)
55c3e87 
* Fix spark docs

Signed-off-by: Kevin Zhang <[email protected]>

* Fix readme.md

Signed-off-by: Kevin Zhang <[email protected]>

* Fix md

Signed-off-by: Kevin Zhang <[email protected]>

Co-authored-by: Danny Chiao <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@kevjumba @adchia @achals
feat: Makefile for contrib for Issue feast-dev#2364 (feast-dev#2366)
f173a1a 
* Add make file

Signed-off-by: Kevin Zhang <[email protected]>

* Fix makefile

Signed-off-by: Kevin Zhang <[email protected]>

* Clean up

Signed-off-by: Kevin Zhang <[email protected]>

* Add documentation

Signed-off-by: Kevin Zhang <[email protected]>

* Clean up

Signed-off-by: Kevin Zhang <[email protected]>

* Update documentation

Signed-off-by: Kevin Zhang <[email protected]>

* update make target

Signed-off-by: Kevin Zhang <[email protected]>

Co-authored-by: Danny Chiao <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@ptoman-pa @achals
Closes threadpool resources upon datastore online_write_batch complet…
1c92201 
…ion (feast-dev#2386)

Signed-off-by: Pamela Toman <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@achals
CR comments
481b8dd 
Signed-off-by: Achal Shah <[email protected]>
@achals
Merge from master again
8f3b96a 
Signed-off-by: Achal Shah <[email protected]>
felixwang9817
felixwang9817 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctkhanhly, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d12e7ef into feast-dev:master Mar 8, 2022
woop
woop reviewed Mar 9, 2022
View reviewed changes
go/cmd/goserver/server_test.go
}

func TestGetFeastServingInfo(t *testing.T) {
t.Skip("@todo(achals): feature_repo isn't checked in yet")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this skipped?

woop
woop reviewed Mar 9, 2022
View reviewed changes
go/cmd/goserver/server_test.go
}

func TestGetOnlineFeatures(t *testing.T) {
t.Skip("@todo(achals): feature_repo isn't checked in yet")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here.

woop
woop reviewed Mar 9, 2022
View reviewed changes
go/internal/feast/errors.go
}

func (e FeatureNameCollisionError) Error() string {
return fmt.Sprintf("featureNameCollisionError: %s; %t", strings.Join(e.featureRefCollisions, ", "), e.fullFeatureNames)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use plain english for the error message instead of an error name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to pass one of the integration tests that requires FeatureNameCollision exception from python sdk. I hacked around by parsing error message to coordinate between 2 languages but would there be a better coordination method I should use instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to prevent polluting the Golang SDK with Python specific requirements. At the very least a translation layer would be useful here to go from a Go error message to this Python one, even if it's hardcoded. It may also be a good idea to eventually introduce error codes instead of having to parse strings.

@achals achals mentioned this pull request Mar 9, 2022
Merged
achals pushed a commit that referenced this pull request Apr 14, 2022
@feast-ci-bot
chore(release): release 0.20.0
b2d2cfd 
# [0.20.0](v0.19.0...v0.20.0) (2022-04-14)

### Bug Fixes

* Add inlined data sources to the top level registry ([#2456](#2456)) ([356788a](356788a))
* Add new value types to types.ts for web ui ([#2463](#2463)) ([ad5694e](ad5694e))
* Add PushSource proto and Python class ([#2428](#2428)) ([9a4bd63](9a4bd63))
* Add spark to lambda dockerfile ([#2480](#2480)) ([514666f](514666f))
* Added private_key auth for Snowflake ([#2508](#2508)) ([c42c9b0](c42c9b0))
* Added Redshift and Spark typecheck to data_source event_timestamp_col inference ([#2389](#2389)) ([04dea73](04dea73))
* Building of go extension fails ([#2448](#2448)) ([7d1efd5](7d1efd5))
* Bump the number of versions bumps expected to 27 ([#2549](#2549)) ([ecc9938](ecc9938))
* Create __init__ files for the proto-generated python dirs ([#2410](#2410)) ([e17028d](e17028d))
* Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. ([#2415](#2415)) ([b95f441](b95f441))
* Dynamodb deduplicate batch write request by partition keys ([#2515](#2515)) ([70d4a13](70d4a13))
* Ensure that __init__ files exist in proto dirs ([#2433](#2433)) ([9b94f7b](9b94f7b))
* Fix DataSource constructor to unbreak custom data sources ([#2492](#2492)) ([712653e](712653e))
* Fix default feast apply path without any extras ([#2373](#2373)) ([6ba7fc7](6ba7fc7))
* Fix definitions.py with new definition ([#2541](#2541)) ([eefc34a](eefc34a))
* Fix entity row to use join key instead of name ([#2521](#2521)) ([c22fa2c](c22fa2c))
* Fix Java Master ([#2499](#2499)) ([e083458](e083458))
* Fix registry proto ([#2435](#2435)) ([ea6a9b2](ea6a9b2))
* Fix some inconsistencies in the docs and comments in the code ([#2444](#2444)) ([ad008bf](ad008bf))
* Fix spark docs ([#2382](#2382)) ([d4a606a](d4a606a))
* Fix Spark template to work correctly on feast init -t spark ([#2393](#2393)) ([ae133fd](ae133fd))
* Fix the feature repo fixture used by java tests  ([#2469](#2469)) ([32e925e](32e925e))
* Fix unhashable Snowflake and Redshift sources ([cd8f1c9](cd8f1c9))
* Fixed bug in passing config file params to snowflake python connector ([#2503](#2503)) ([34f2b59](34f2b59))
* Fixing Spark template to include source name ([#2381](#2381)) ([a985f1d](a985f1d))
* Make name a keyword arg for the Entity class ([#2467](#2467)) ([43847de](43847de))
* Making a name for data sources not a breaking change ([#2379](#2379)) ([71d7ae2](71d7ae2))
* Minor link fix in `CONTRIBUTING.md` ([#2481](#2481)) ([2917e27](2917e27))
* Preserve ordering of features in _get_column_names ([#2457](#2457)) ([495b435](495b435))
* Relax click python requirement to >=7 ([#2450](#2450)) ([f202f92](f202f92))
* Remove date partition column field from datasources that don't s… ([#2478](#2478)) ([ce35835](ce35835))
* Remove docker step from unit test workflow ([#2535](#2535)) ([6f22f22](6f22f22))
* Remove spark from the AWS Lambda dockerfile ([#2498](#2498)) ([6abae16](6abae16))
* Request data api update ([#2488](#2488)) ([0c9e5b7](0c9e5b7))
* Schema update ([#2509](#2509)) ([cf7bbc2](cf7bbc2))
* Simplify DataSource.from_proto logic ([#2424](#2424)) ([6bda4d2](6bda4d2))
* Snowflake api update ([#2487](#2487)) ([1181a9e](1181a9e))
* Support passing batch source to streaming sources for backfills ([#2523](#2523)) ([90db1d1](90db1d1))
* Timestamp update ([#2486](#2486)) ([bf23111](bf23111))
* Typos in Feast UI error message ([#2432](#2432)) ([e14369d](e14369d))
* Update feature view APIs to prefer keyword args ([#2472](#2472)) ([7c19cf7](7c19cf7))
* Update file api ([#2470](#2470)) ([83a11c6](83a11c6))
* Update Makefile to cd into python dir before running commands ([#2437](#2437)) ([ca32155](ca32155))
* Update redshift api ([#2479](#2479)) ([4fa73a9](4fa73a9))
* Update some fields optional in UI parser ([#2380](#2380)) ([cff7ac3](cff7ac3))
* Use a single version of jackson libraries and upgrade to 2.12.6.1 ([#2473](#2473)) ([5be1cc6](5be1cc6))
* Use dateutil parser to parse materialization times ([#2464](#2464)) ([6c55e49](6c55e49))
* Use the correct dockerhub image tag when building feature servers ([#2372](#2372)) ([0d62c1d](0d62c1d))

### Features

* Add `/write-to-online-store` method to the python feature server ([#2423](#2423)) ([d2fb048](d2fb048))
* Add description, tags, owner fields to all feature view classes ([#2440](#2440)) ([ed5e928](ed5e928))
* Add DQM Logging on GRPC Server with FileLogStorage for Testing ([#2403](#2403)) ([57a97d8](57a97d8))
* Add Feast types in preparation for changing type system ([#2475](#2475)) ([4864252](4864252))
* Add Field class ([#2500](#2500)) ([1279612](1279612))
* Add support for DynamoDB online_read in batches ([#2371](#2371)) ([702ec49](702ec49))
* Add Support for DynamodbOnlineStoreConfig endpoint_url parameter ([#2485](#2485)) ([7b863d1](7b863d1))
* Add templating for dynamodb table name ([#2394](#2394)) ([f591088](f591088))
* Allow local feature server to use Go feature server if enabled ([#2538](#2538)) ([a2ef375](a2ef375))
* Allow using entity's join_key in get_online_features ([#2420](#2420)) ([068c765](068c765))
* Data Source Api Update ([#2468](#2468)) ([6b96b21](6b96b21))
* Go server ([#2339](#2339)) ([d12e7ef](d12e7ef)), closes [#2354](#2354) [#2361](#2361) [#2332](#2332) [#2356](#2356) [#2363](#2363) [#2349](#2349) [#2355](#2355) [#2336](#2336) [#2361](#2361) [#2363](#2363) [#2344](#2344) [#2354](#2354) [#2347](#2347) [#2350](#2350) [#2356](#2356) [#2355](#2355) [#2349](#2349) [#2352](#2352) [#2341](#2341) [#2336](#2336) [#2373](#2373) [#2315](#2315) [#2372](#2372) [#2332](#2332) [#2349](#2349) [#2336](#2336) [#2361](#2361) [#2363](#2363) [#2344](#2344) [#2354](#2354) [#2347](#2347) [#2350](#2350) [#2356](#2356) [#2355](#2355) [#2349](#2349) [#2352](#2352) [#2341](#2341) [#2336](#2336) [#2373](#2373) [#2379](#2379) [#2380](#2380) [#2382](#2382) [#2364](#2364) [#2366](#2366) [#2386](#2386)
* Graduate write_to_online_store out of experimental status ([#2426](#2426)) ([e7dd4b7](e7dd4b7))
* Make feast PEP 561 compliant ([#2405](#2405)) ([3c41f94](3c41f94)), closes [#2420](#2420) [#2418](#2418) [#2425](#2425) [#2426](#2426) [#2427](#2427) [#2431](#2431) [#2433](#2433) [#2420](#2420) [#2418](#2418) [#2425](#2425) [#2426](#2426) [#2427](#2427) [#2431](#2431) [#2433](#2433)
* Makefile for contrib for Issue [#2364](#2364) ([#2366](#2366)) ([a02325b](a02325b))
* Support on demand feature views in go feature server ([#2494](#2494)) ([6edd274](6edd274))
* Switch from Feature to Field ([#2514](#2514)) ([6a03bed](6a03bed))
* Use a daemon thread to monitor the go feature server exclusively ([#2391](#2391)) ([0bb5e8c](0bb5e8c))
@zhilingc zhilingc mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

@woop woop woop left review comments

@achals achals achals left review comments

@pyalex pyalex pyalex left review comments

@adchia adchia Awaiting requested review from adchia

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@tsotnet tsotnet

@woop woop

@felixwang9817 felixwang9817

Labels
approved kind/feature New feature or request lgtm ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.