Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf pinned to <3.20.0 #2484

Closed
achals opened this issue Apr 4, 2022 · 0 comments · Fixed by #2894
Closed

protobuf pinned to <3.20.0 #2484

achals opened this issue Apr 4, 2022 · 0 comments · Fixed by #2894
Assignees
@adchia
Labels
kind/bug priority/p2

Comments

@achals
Copy link
Member

achals commented Apr 4, 2022

We pinned the version of protobuf to protobuf>=3.10,<3.20 because we patch some functionality when converting json <> proto in the AWS Lambda feature server (https://github.com/feast-dev/feast/blob/master/sdk/python/feast/proto_json.py#L18).

protobuf 3.20.0 changes the API we patch - so the version bump needs to happen along with an update to the patched methods.

#2480 has more context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adchia adchia

Labels
kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix grpc and update protobuf kevjumba/feast
2 participants
@achals @adchia