fix: Fix grpc and update protobuf #2894

kevjumba · 2022-06-29T23:27:01Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

codecov-commenter · 2022-06-30T00:12:09Z

Codecov Report

Merging #2894 (7a7a473) into master (8e2a375) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
- Coverage   80.68%   80.62%   -0.06%     
==========================================
  Files         176      176              
  Lines       15670    15670              
==========================================
- Hits        12643    12634       -9     
- Misses       3027     3036       +9

Flag	Coverage Δ
integrationtests	`70.78% <50.00%> (-0.13%)`	⬇️
unittests	`59.34% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	`0.00% <ø> (ø)`
sdk/python/feast/proto_json.py	`92.42% <100.00%> (ø)`
sdk/python/tests/unit/test_proto_json.py	`100.00% <100.00%> (ø)`
sdk/python/tests/utils/online_read_write_test.py	`93.54% <0.00%> (-6.46%)`	⬇️
.../integration/online_store/test_online_retrieval.py	`96.84% <0.00%> (-3.16%)`	⬇️
sdk/python/feast/infra/online_stores/datastore.py	`87.96% <0.00%> (-1.39%)`	⬇️
...ython/feast/embedded_go/online_features_service.py	`89.39% <0.00%> (-0.76%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2a375...7a7a473. Read the comment docs.

achals · 2022-06-30T01:13:50Z

.github/workflows/build_wheels.yml

@@ -1,7 +1,11 @@
 name: build_wheels

 # Call this workflow from other workflows in the repository by specifying "uses: ./.github/workflows/build_wheels.yml"
-on: [workflow_dispatch, workflow_call]
+on:


This should be a different PR

achals · 2022-06-30T01:14:10Z

.github/workflows/build_wheels.yml

@@ -76,10 +80,10 @@ jobs:
            make install-protoc-dependencies
            make install-go-proto-dependencies
            make install-go-ci-dependencies
-            git status
-            git restore go.mod go.sum
+          # git status


Why are we removing this? And if we are it should be in a different PR

Oh Let me change that.

achals · 2022-06-30T01:14:46Z

.github/workflows/build_wheels.yml

@@ -134,7 +138,7 @@ jobs:

  verify-python-wheels:
    runs-on: ${{ matrix.os }}
-    needs: [build-python-wheel, build-source-distribution]
+    needs: [build-python-wheel, build-source-distribution, get-version]


Why is this change needed?

we need to give the job access the release version which means we must add it to needs

achals · 2022-06-30T02:48:06Z

sdk/python/requirements/py3.7-requirements.txt

@@ -0,0 +1,202 @@
+#


Why are we adding this back?

ah lol, I didnt realize we had already removed 3.7 requirements.

achals · 2022-06-30T02:48:17Z

sdk/python/requirements/py3.7-ci-requirements.txt

@@ -0,0 +1,806 @@
+#


Why are we adding this back?

same as above

achals · 2022-06-30T02:48:46Z

setup.py

    "Jinja2>=2,<4",
    "jsonschema",
    "mmh3",
    "numpy<1.22,<2",
    "pandas>=1,<2",
    "pandavro==1.5.*",
-    "protobuf>=3.10,<3.20",
+    "protobuf>=3.10,<4",


Suggested change

"protobuf>=3.10,<4",

"protobuf>3.20,<4",

Signed-off-by: Kevin Zhang <[email protected]>

felixwang9817

/lgtm

feast-ci-bot · 2022-06-30T16:56:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Test Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix workflow Signed-off-by: Kevin Zhang <[email protected]> * Fix workflow Signed-off-by: Kevin Zhang <[email protected]> * Test Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * test Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * test Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix protobuf pin version and add path variable Signed-off-by: Kevin Zhang <[email protected]> * Revert setup Signed-off-by: Kevin Zhang <[email protected]> * Update 3.8 Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Update 3.10 Signed-off-by: Kevin Zhang <[email protected]> * update Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix test Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Update go with grpc 1.47 Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]>

## [0.22.1](v0.22.0...v0.22.1) (2022-07-19) ### Bug Fixes * Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887)) ([b9190b9](b9190b9)) * Change the feature store plan method to public modifier ([#2904](#2904)) ([568058a](568058a)) * Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934)) ([146e36d](146e36d)) * Fix build wheels workflow to install apache-arrow correctly ([#2932](#2932)) ([4b69e0e](4b69e0e)) * Fix grpc and update protobuf ([#2894](#2894)) ([f726c96](f726c96)) * Fix night ci syntax error and update readme ([#2935](#2935)) ([b35553b](b35553b)) * Fix nightly ci again ([#2939](#2939)) ([c363619](c363619)) * Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection ([#2919](#2919)) ([f4f4894](f4f4894)) * Fixing broken links to feast documentation on java readme and contribution ([#2892](#2892)) ([a45e10a](a45e10a)) * Resolve small typo in README file ([#2930](#2930)) ([9840c1b](9840c1b)) * Update gopy to point to fork to resolve github annotation errors. ([#2940](#2940)) ([9b9fbbe](9b9fbbe))

# [0.23.0](v0.22.0...v0.23.0) (2022-08-02) ### Bug Fixes * Add dummy alias to pull_all_from_table_or_query ([#2956](#2956)) ([5e45228](5e45228)) * Bump version of Guava to mitigate cve ([#2896](#2896)) ([51df8be](51df8be)) * Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887)) ([80ea7a9](80ea7a9)) * Change the feature store plan method to public modifier ([#2904](#2904)) ([0ec7d1a](0ec7d1a)) * Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934)) ([040c910](040c910)) * Do not allow same column to be reused in data sources ([#2965](#2965)) ([661c053](661c053)) * Fix build wheels workflow to install apache-arrow correctly ([#2932](#2932)) ([bdeb4ae](bdeb4ae)) * Fix file offline store logic for feature views without ttl ([#2971](#2971)) ([26f6b69](26f6b69)) * Fix grpc and update protobuf ([#2894](#2894)) ([86e9efd](86e9efd)) * Fix night ci syntax error and update readme ([#2935](#2935)) ([b917540](b917540)) * Fix nightly ci again ([#2939](#2939)) ([1603c9e](1603c9e)) * Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection ([#2919](#2919)) ([130746e](130746e)) * Fix typo in CONTRIBUTING.md ([#2955](#2955)) ([8534f69](8534f69)) * Fixing broken links to feast documentation on java readme and contribution ([#2892](#2892)) ([d044588](d044588)) * Fixing Spark min / max entity df event timestamps range return order ([#2735](#2735)) ([ac55ce2](ac55ce2)) * Move gcp back to 1.47.0 since grpcio-tools 1.48.0 got yanked from pypi ([#2990](#2990)) ([fc447eb](fc447eb)) * Refactor testing and sort out unit and integration tests ([#2975](#2975)) ([2680f7b](2680f7b)) * Remove hard-coded integration test setup for AWS & GCP ([#2970](#2970)) ([e4507ac](e4507ac)) * Resolve small typo in README file ([#2930](#2930)) ([16ae902](16ae902)) * Revert "feat: Add snowflake online store ([#2902](#2902))" ([#2909](#2909)) ([38fd001](38fd001)) * Snowflake_online_read fix ([#2988](#2988)) ([651ce34](651ce34)) * Spark source support table with pattern "db.table" ([#2606](#2606)) ([3ce5139](3ce5139)), closes [#2605](#2605) * Switch mysql log string to use regex ([#2976](#2976)) ([5edf4b0](5edf4b0)) * Update gopy to point to fork to resolve github annotation errors. ([#2940](#2940)) ([ba2dcf1](ba2dcf1)) * Version entity serialization mechanism and fix issue with int64 vals ([#2944](#2944)) ([d0d27a3](d0d27a3)) ### Features * Add an experimental lambda-based materialization engine ([#2923](#2923)) ([6f79069](6f79069)) * Add column reordering to `write_to_offline_store` ([#2876](#2876)) ([8abc2ef](8abc2ef)) * Add custom JSON table tab w/ formatting ([#2851](#2851)) ([0159f38](0159f38)) * Add CustomSourceOptions to SavedDatasetStorage ([#2958](#2958)) ([23c09c8](23c09c8)) * Add Go option to `feast serve` command ([#2966](#2966)) ([a36a695](a36a695)) * Add interfaces for batch materialization engine ([#2901](#2901)) ([38b28ca](38b28ca)) * Add pages for individual Features to the Feast UI ([#2850](#2850)) ([9b97fca](9b97fca)) * Add snowflake online store ([#2902](#2902)) ([f758f9e](f758f9e)), closes [#2903](#2903) * Add Snowflake online store (again) ([#2922](#2922)) ([2ef71fc](2ef71fc)), closes [#2903](#2903) * Add to_remote_storage method to RetrievalJob ([#2916](#2916)) ([109ee9c](109ee9c)) * Support retrieval from multiple feature views with different join keys ([#2835](#2835)) ([056cfa1](056cfa1))

kevjumba added do-not-merge/work-in-progress ok-to-test labels Jun 29, 2022

feast-ci-bot added approved size/XXL and removed do-not-merge/work-in-progress labels Jun 29, 2022

kevjumba added do-not-merge/work-in-progress ok-to-test and removed ok-to-test labels Jun 29, 2022

feast-ci-bot removed the do-not-merge/work-in-progress label Jun 30, 2022

achals reviewed Jun 30, 2022

View reviewed changes

kevjumba added 18 commits June 29, 2022 20:35

Test

dd52cbc

Signed-off-by: Kevin Zhang <[email protected]>

Fix

2f6fbc2

Signed-off-by: Kevin Zhang <[email protected]>

Fix workflow

9fa6cd5

Signed-off-by: Kevin Zhang <[email protected]>

Fix workflow

b7b2c11

Signed-off-by: Kevin Zhang <[email protected]>

Test

7c0e972

Signed-off-by: Kevin Zhang <[email protected]>

Fix

ad47069

Signed-off-by: Kevin Zhang <[email protected]>

Fix

160c18e

Signed-off-by: Kevin Zhang <[email protected]>

Fix

f782488

Signed-off-by: Kevin Zhang <[email protected]>

test

985d672

Signed-off-by: Kevin Zhang <[email protected]>

Fix

2fa19af

Signed-off-by: Kevin Zhang <[email protected]>

Fix

fa91bea

Signed-off-by: Kevin Zhang <[email protected]>

Fix

8edd89d

Signed-off-by: Kevin Zhang <[email protected]>

Fix

d5f2000

Signed-off-by: Kevin Zhang <[email protected]>

test

c24fee0

Signed-off-by: Kevin Zhang <[email protected]>

Fix

0c7cb35

Signed-off-by: Kevin Zhang <[email protected]>

Fix protobuf pin version and add path variable

9027a59

Signed-off-by: Kevin Zhang <[email protected]>

Revert setup

1edb15c

Signed-off-by: Kevin Zhang <[email protected]>

Update 3.8

25b090d

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba added 9 commits June 29, 2022 20:38

Fix

61e1aec

Signed-off-by: Kevin Zhang <[email protected]>

Update 3.10

f75d9ab

Signed-off-by: Kevin Zhang <[email protected]>

update

3b39aaa

Signed-off-by: Kevin Zhang <[email protected]>

Fix

278cda7

Signed-off-by: Kevin Zhang <[email protected]>

Fix

3d63de0

Signed-off-by: Kevin Zhang <[email protected]>

Fix

698e335

Signed-off-by: Kevin Zhang <[email protected]>

Fix test

2b8cbe9

Signed-off-by: Kevin Zhang <[email protected]>

Fix

4f5ec88

Signed-off-by: Kevin Zhang <[email protected]>

Update go with grpc 1.47

c7c9ff1

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba force-pushed the fix_grpc branch from eb818e8 to c7c9ff1 Compare June 30, 2022 03:39

kevjumba added 2 commits June 29, 2022 20:40

Fix

ca1fd4b

Signed-off-by: Kevin Zhang <[email protected]>

Fix

d875c61

Signed-off-by: Kevin Zhang <[email protected]>

feast-ci-bot added size/L and removed size/XXL labels Jun 30, 2022

kevjumba added 2 commits June 29, 2022 20:44

Fix

c6d2ef7

Signed-off-by: Kevin Zhang <[email protected]>

Fix

7a7a473

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba requested a review from achals June 30, 2022 05:29

felixwang9817 approved these changes Jun 30, 2022

View reviewed changes

feast-ci-bot assigned felixwang9817 Jun 30, 2022

feast-ci-bot added the lgtm label Jun 30, 2022

feast-ci-bot merged commit 86e9efd into feast-dev:master Jun 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix grpc and update protobuf #2894

fix: Fix grpc and update protobuf #2894

kevjumba commented Jun 29, 2022 •

edited

Loading

codecov-commenter commented Jun 30, 2022 •

edited

Loading

achals Jun 30, 2022

achals Jun 30, 2022

kevjumba Jun 30, 2022

achals Jun 30, 2022

kevjumba Jun 30, 2022

achals Jun 30, 2022

kevjumba Jun 30, 2022

achals Jun 30, 2022

kevjumba Jun 30, 2022

achals Jun 30, 2022

kevjumba Jun 30, 2022

felixwang9817 left a comment

feast-ci-bot commented Jun 30, 2022

fix: Fix grpc and update protobuf #2894

fix: Fix grpc and update protobuf #2894

Conversation

kevjumba commented Jun 29, 2022 • edited Loading

codecov-commenter commented Jun 30, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Jun 30, 2022

kevjumba commented Jun 29, 2022 •

edited

Loading

codecov-commenter commented Jun 30, 2022 •

edited

Loading