Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requested features on Postgresql online store #3173

Closed
NhuanTDBK opened this issue Sep 3, 2022 · 3 comments · Fixed by #3203
Closed

Support requested features on Postgresql online store #3173

NhuanTDBK opened this issue Sep 3, 2022 · 3 comments · Fixed by #3203
Labels
kind/feature New feature or request

Comments

@NhuanTDBK
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a user, I want to retrieve subset of features on Postgresql online store instead of fetching all features

Describe the solution you'd like
Update online_read method to retrieve subset of features

Additional context
I'm close to creating a pull request for this issue myself.

@felixwang9817
Copy link
Collaborator

hey @NhuanTDBK, are you sure that Postgres currently doesn't support retrieving a subset of features?

I took a quick look at #3203 and I noticed that the sqlite online store online_read method also does not make use of requested_features; that is because later on the requested features are correctly subselected in FeatureStore._read_from_online_store here

I would be surprised if this didn't also work for Postgres

@NhuanTDBK
Copy link
Contributor Author

@felixwang9817 I think it's more efficient when it pushed down predicates to Postgres instead of fetching all features and filter out in the client side (For this case, we want to build the AutoFeatureSelection module to automatically select the best features from thousand of features)

@felixwang9817
Copy link
Collaborator

@NhuanTDBK sorry for the slow response here - that makes sense to me, I'll stamp your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
2 participants