Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter subset features in postgres #3174

Closed
wants to merge 4 commits into from
Closed

feat: Filter subset features in postgres #3174

wants to merge 4 commits into from

Conversation

NhuanTDBK
Copy link
Contributor

@NhuanTDBK NhuanTDBK commented Sep 3, 2022

Signed-off-by: Steve Tran [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3173

Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NhuanTDBK can you please sign your commits to resolve the DCO

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevjumba, NhuanTDBK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevjumba kevjumba changed the title Feat: Filter subset features feat: Filter subset features in postgres Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Base: 66.85% // Head: 66.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5e4e8e7) compared to base (d7b0c52).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
- Coverage   66.85%   66.85%   -0.01%     
==========================================
  Files         175      175              
  Lines       15848    15850       +2     
==========================================
+ Hits        10595    10596       +1     
- Misses       5253     5254       +1     
Flag Coverage Δ
integrationtests 66.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 55.88% <0.00%> (-0.48%) ⬇️
sdk/python/feast/feature_store.py 82.00% <0.00%> (-0.07%) ⬇️
...on/feast/infra/materialization/snowflake_engine.py 92.09% <0.00%> (-0.05%) ⬇️
sdk/python/feast/infra/online_stores/snowflake.py 97.97% <0.00%> (-0.03%) ⬇️
sdk/python/feast/infra/provider.py 77.94% <0.00%> (ø)
sdk/python/feast/infra/passthrough_provider.py 96.29% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/snowflake.py 92.95% <0.00%> (ø)
sdk/python/feast/feature_view.py 95.06% <0.00%> (+0.06%) ⬆️
sdk/python/tests/utils/e2e_test_validation.py 89.10% <0.00%> (+0.33%) ⬆️
.../infra/materialization/aws_lambda/lambda_engine.py 93.61% <0.00%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

felixwang9817 and others added 3 commits September 10, 2022 10:31
Add `value_type` parameter back to entities

Signed-off-by: Felix Wang <[email protected]>

Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
…more (#3163)

* docs: Cleanup running Feast in production, fix links, and call out Slack more

Signed-off-by: Danny Chiao <[email protected]>

* fix title

Signed-off-by: Danny Chiao <[email protected]>

* fix title

Signed-off-by: Danny Chiao <[email protected]>

* remove workshop

Signed-off-by: Danny Chiao <[email protected]>

* remove toc

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
@NhuanTDBK NhuanTDBK closed this Sep 10, 2022
@NhuanTDBK NhuanTDBK reopened this Sep 10, 2022
@NhuanTDBK NhuanTDBK closed this Sep 10, 2022
feast-ci-bot pushed a commit that referenced this pull request Sep 22, 2022
* Filter subset features

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>

* Fix python lint

Signed-off-by: NHUAN.TRAN <[email protected]>

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
Co-authored-by: NHUAN.TRAN <[email protected]>
felixwang9817 pushed a commit to felixwang9817/feast that referenced this pull request Sep 26, 2022
* Filter subset features

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>

* Fix python lint

Signed-off-by: NHUAN.TRAN <[email protected]>

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
Co-authored-by: NHUAN.TRAN <[email protected]>
vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022
* Filter subset features

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>

* Fix python lint

Signed-off-by: NHUAN.TRAN <[email protected]>

Signed-off-by: NHUAN.TRAN <[email protected]>
Signed-off-by: NHUAN.TRAN <[email protected]>
Co-authored-by: NHUAN.TRAN <[email protected]>
kevjumba pushed a commit that referenced this pull request Oct 6, 2022
# [0.26.0](v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7))
* Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb))
* Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([#3267](#3267)) ([a9d48d0](a9d48d0))
* Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01))
* Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f))
* Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda))
* Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1))

### Features

* Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19))
* Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757))
* Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f))
* BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Oct 18, 2022
# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb))
* Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01))
* Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda))
* Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1))

### Features

* Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19))
* Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757))
* Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f))
* BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support requested features on Postgresql online store
6 participants