fix: Use configured user in env var instead of "user" for Trino

[ammarar]

Signed-off-by: ammarar [email protected]

What this PR does / why we need it: To use the configured user specified in env var. The current way is incorrect since it shadows whatever the user provides.

Which issue(s) this PR fixes:

Fixes #

[codecov-commenter]

Codecov Report

Base: 67.46% // Head: 76.25% // Increases project coverage by +8.79% 🎉

Coverage data is based on head (76a2a1a) compared to base (e713dda).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3254      +/-   ##
==========================================
+ Coverage   67.46%   76.25%   +8.79%     
==========================================
  Files         179      216      +37     
  Lines       16402    18820    +2418     
==========================================
+ Hits        11065    14351    +3286     
+ Misses       5337     4469     -868     

Flag	Coverage Δ
integrationtests	67.32% <ø> (-0.14%)	⬇️
unittests	58.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ffline_stores/contrib/trino_offline_store/trino.py	8.78% <ø> (ø)
...ests/integration/e2e/test_python_feature_server.py	82.14% <0.00%> (-17.86%)	⬇️
sdk/python/feast/feature_server.py	56.75% <0.00%> (-14.13%)	⬇️
sdk/python/feast/feature_store.py	78.64% <0.00%> (-3.37%)	⬇️
...on/feast/infra/materialization/snowflake_engine.py	93.18% <0.00%> (-0.41%)	⬇️
...tion/contrib/spark/spark_materialization_engine.py	71.84% <0.00%> (-0.28%)	⬇️
sdk/python/feast/loaders/yaml.py	18.18% <0.00%> (ø)
...thon/feast/infra/online_stores/contrib/postgres.py	32.07% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py	17.64% <0.00%> (ø)
...offline_stores/contrib/mssql_repo_configuration.py	100.00% <0.00%> (ø)
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adchia]

This doesn't seem to use a given environment variable? Also does it make sense to have this instead in TrinoOfflineStoreConfig?

[ammarar]

@adchia the environment variable will be evaluated later in here. My actual preference in general is maybe to have multiple level of evaluation of these configurations. It can be in TrinoOfflineStoreConfig, if it doesn't find it, it can look into an env var. if it doesn't find it, it can use default. However, I haven't seen that pattern in the code, thats why I did it this way.

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, ammarar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment