Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move google-api-core/googleapis-common-protos depdencies to extras #3458

Closed
cburroughs opened this issue Jan 20, 2023 · 1 comment
Closed

move google-api-core/googleapis-common-protos depdencies to extras #3458

cburroughs opened this issue Jan 20, 2023 · 1 comment
Labels
kind/feature New feature or request wontfix This will not be worked on

Comments

@cburroughs
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Feast currently requires

    "google-api-core>=1.23.0,<3",
    "googleapis-common-protos>=1.52.*,<2",

As core dependencies. I'd expect google cloud apis to not be a requirement to use (for example) AWS and my naive grepping of the code didn't turn up any obvious counter examples. From the git blame chain it looks like there were not yet any precedents for extras when these were added: https://github.com/feast-dev/feast/blame/0da112b363b6e67a95ead3d95c209be301db56a5/sdk/python/setup.py

Describe the solution you'd like

I presume they could move to GCP_REQUIRED or another section.

Additional context
I noticed this because where adding feast as a dependency to an existing project has caused pip's resolve to take 10s of minutes. Based on the the plethora of INFO: pip is looking at multiple versions of google-api-core to determine which version is compatible with other requirements. This could take a while. I suspect these are particularly tricky dependencies for pip satisfy.
@cburroughs cburroughs added the kind/feature New feature or request label Jan 20, 2023
@cburroughs cburroughs mentioned this issue Jan 24, 2023
Merged
adchia pushed a commit to cburroughs/feast that referenced this issue Jan 30, 2023
@cburroughs @adchia
ci: Move google-api dependencies to GCP extras
1c0fcd3 
These dependencies were added before any extras existed in setup.py.
Feast users would generally expect that using AWS or Azure does not
require Google Cloud apis.

Fixex feast-dev#3458

Signed-off-by: Chris Burroughs <[email protected]>
feast-ci-bot pushed a commit that referenced this issue Feb 13, 2023
@cburroughs @adchia
chore: Move google-api dependencies to GCP extras (#3463)
378edef 
* ci: Move google-api dependencies to GCP extras

These dependencies were added before any extras existed in setup.py.
Feast users would generally expect that using AWS or Azure does not
require Google Cloud apis.

Fixex #3458

Signed-off-by: Chris Burroughs <[email protected]>

* update requirements

Signed-off-by: Danny Chiao <[email protected]>

---------

Signed-off-by: Chris Burroughs <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Co-authored-by: Danny Chiao <[email protected]>
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cburroughs