feat: Set optional full-scan for deletion #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiwon Park <[email protected]>
|
I think this might be valuable in the interim, although you might want to chime in the discussion here as well #4133. The implicit consensus from there is to add a |
breno-costa
reviewed
May 14, 2024
|
|
||
| for table in tables_to_delete: | ||
| self.delete_table(config, table) | ||
| if online_store_config.full_scan_for_deletion: |
There was a problem hiding this comment.
the old implementation deletes tables by default.
should full_scan_for_deletion's default value be True?
There was a problem hiding this comment.
As you said, I set default to True for compatibility with older implementations.
If compatibility is not enforced, I think False would be better.
There was a problem hiding this comment.
@breno-costa Changed to default True to ensure backward compatibility
Signed-off-by: Jiwon Park <[email protected]>
franciscojavierarceo
approved these changes
May 27, 2024
franciscojavierarceo
pushed a commit
that referenced
this pull request
May 27, 2024
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In this link (#3857), I added function to perform a full-scan and delete data to save Redis memory. However, full-scan in Redis does not work beautifully, takes too long at production scale, and often fails in CI that performs feast-apply. So, I think it would be a good idea to add the 'full_scan_for_deletion' option in redis so that the user can select and delete it.
Which issue(s) this PR fixes:
Fixes