feat: Adding vector search for sqlite #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
force-pushed
the
get-online-documents-tests
branch
2 times, most recently
from
1ace4cd
to
8e9dcb2
Compare
franciscojavierarceo
force-pushed
the
get-online-documents-tests
branch
from
fa18a2c
to
5471399
Compare
franciscojavierarceo
force-pushed
the
get-online-documents-tests
branch
2 times, most recently
from
5241ae1
to
caba2c1
Compare
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
force-pushed
the
get-online-documents-tests
branch
from
caba2c1
to
59e8b40
Compare
…l table insertion Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…e view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
tokoko
reviewed
Jun 10, 2024
setup.py
Outdated
| @@ -56,6 +56,7 @@ | |||
| "pygments>=2.12.0,<3", | |||
| "PyYAML>=5.4.0,<7", | |||
| "requests", | |||
| "sqlite-vec==v0.0.1-alpha.10", | |||
There was a problem hiding this comment.
How about we put this under sqlite extra?
There was a problem hiding this comment.
👍 put it under sqlite_vec extra
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
redhatHameed
pushed a commit
to RHEcosystemAppEng/feast
that referenced
this pull request
Jun 10, 2024
* feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> Signed-off-by: Abdul Hameed <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 12, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 12, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds Vector Search using SQLite https://github.com/asg017/sqlite-vec.
Currently,
sqlite-vecis in alpha mode and the build only works on Mac-OS and Python 3.10. This was confirmed in this run.The usage is simple:
Which issue(s) this PR fixes:
#4209