Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup e2e and docker-compose tests #1035

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

terryyylim
Copy link
Member

@terryyylim terryyylim commented Oct 8, 2020

What this PR does / why we need it:
Fixes the following:

  1. docker-compose test are currently failing due to missing GCP credentials
  2. Usage of polling instead of sleep for e2e tests
  3. Using BQ source should allow dataset to contain underscore
  4. Flaky e2e test due to ordering of entities and features (which are returned as a set)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Oct 8, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 5dd68a8 into feast-dev:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants