Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make created timestamp column optional #1108

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented Oct 29, 2020

Signed-off-by: Khor Shu Heng [email protected]

What this PR does / why we need it:
Currently, created timestamp columns are mandatory arguments for Datasource. While this is true for Feature Table datasource, it should be optional for Entity datasource. This PR will make created timestamp column optional for DataSource, BigQuerySource and FileSource.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@khorshuheng khorshuheng changed the title (WIP) Make created timestamp column optional Make created timestamp column optional Oct 29, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Oct 29, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 4699d58 into feast-dev:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants