Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confluent kafka installation to minimal notebook #1116

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

woop
Copy link
Member

@woop woop commented Oct 30, 2020

What this PR does / why we need it:

The current minimal Jupyter notebook doesn't work because it requires confluent_kafka to be installed.

Does this PR introduce a user-facing change?:

None

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit f8a640d into feast-dev:master Oct 30, 2020
@feast-ci-bot
Copy link
Collaborator

@woop: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
python-sdk-integration-test 6eaf9a1 link /test python-sdk-integration-test
test-end-to-end-gcp 6eaf9a1 link /test test-end-to-end-gcp

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants