Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop hardcoded FEAST_CORE_URL env from JobService helm chart #1136

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 5, 2020

Signed-off-by: Oleksii Moskalenko [email protected]

What this PR does / why we need it:

Core Service name can be overridden on helm installation, so FEAST_CORE_URL should not be hardcoded in helm chart

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex merged commit 9285bd8 into feast-dev:master Nov 5, 2020
@feast-ci-bot
Copy link
Collaborator

@pyalex: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-aws cf4f4bc link /test test-end-to-end-aws
test-end-to-end-gcp cf4f4bc link /test test-end-to-end-gcp

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants