Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing third_party folder #1185

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

terryyylim
Copy link
Member

@terryyylim terryyylim commented Nov 20, 2020

Signed-off-by: Terence [email protected]

What this PR does / why we need it:
third_party folder was added from creation of job service but not initialized.
This causes the following error when using the cli.

from feast.third_party.grpc.health.v1 import HealthService_pb2_grpc
ModuleNotFoundError: No module named 'feast.third_party'

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khorshuheng
Copy link
Collaborator

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 912376c into feast-dev:master Nov 20, 2020
pyalex pushed a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants