docs, fixes and scripts to run e2e tests in minikube #1254
Conversation
Signed-off-by: Oleg Avdeev <[email protected]>
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
tests/README.md
Outdated
| ```bash | ||
| # | ||
| # NB!! make sure to use bash 5.0+ for the next step. You'd need to brew install it on OSX | ||
| DOCKER_REPOSITORY=gcr.io/kf-feast GIT_TAG=develop bash ./infra/scripts/setuplocal.sh |
There was a problem hiding this comment.
yep good catch, that was a last minute rename
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
|
/kind housekeeping |
| @@ -0,0 +1,109 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
can we combine this with infra/scripts/runner-helper.sh
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
|
@oavdeev: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test test-end-to-end-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
| if ! time helm install --wait "$RELEASE" infra/charts/feast \ | ||
| --timeout 15m \ | ||
| if ! time helm install --wait "$RELEASE" ./infra/charts/feast \ | ||
| --timeout 5m \ |
There was a problem hiding this comment.
the azure test requires >5min (15 to be safe), I believe because of some services requiring others to be up + crashloopbackoff. Probably could be fixed but I had just increased the timeout
There was a problem hiding this comment.
Ok rolled this back, but this is peculiar since on EKS it usually takes maybe a minute, and you'd think this is pure k8s stuff that shouldn't depend on the cloud provider much.
Signed-off-by: Oleg Avdeev <[email protected]>
|
New changes are detected. LGTM label has been removed. |
| def _get_staging_client(self): | ||
| uri = urlparse(self._staging_location) | ||
| return get_staging_client(uri.scheme, self._config) | ||
|
|
||
| def _get_azure_credentials(self): |
There was a problem hiding this comment.
I had changed it recently to just pass in the whole config but if we don't want to do that, then this function needs the Azure blob account name and access key passed in
What this PR does / why we need it:
This contains a doc describing how to run e2e tests in minikube, and some fixes and scripts to make that work.
The fixes are to make sure custom S3 endpoints are used throughout by Feast and tests, so it can run against minio.
Does this PR introduce a user-facing change?: