Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow https url for spark ingestion jar #1266

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 14, 2021

Signed-off-by: Jacob Klegar [email protected]

What this PR does / why we need it: previously if the spark ingestion jar was a https url (which is the default), ingestion would fail because Feast would try to read and upload the jar as if the url were a local path

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@woop
Copy link
Member

woop commented Jan 14, 2021

@jklegar so this change doesn't apply to dataproc?

@jklegar
Copy link
Collaborator Author

jklegar commented Jan 14, 2021

I believe on dataproc https should already work due to

if not os.path.isfile(file_path):

@oavdeev
Copy link
Collaborator

oavdeev commented Jan 15, 2021

/retest

@oavdeev
Copy link
Collaborator

oavdeev commented Jan 16, 2021

/test test-end-to-end-aws

Signed-off-by: Jacob Klegar <[email protected]>
@jklegar
Copy link
Collaborator Author

jklegar commented Jan 18, 2021

/test test-end-to-end-aws

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jklegar, oavdeev
To complete the pull request process, please assign zhilingc after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants