-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow https url for spark ingestion jar #1266
Conversation
@jklegar so this change doesn't apply to dataproc? |
I believe on dataproc https should already work due to
|
/retest |
/test test-end-to-end-aws |
Signed-off-by: Jacob Klegar <[email protected]>
Signed-off-by: Jacob Klegar <[email protected]>
c2085f4
to
dead34c
Compare
/test test-end-to-end-aws |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jklegar, oavdeev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jacob Klegar [email protected]
What this PR does / why we need it: previously if the spark ingestion jar was a https url (which is the default), ingestion would fail because Feast would try to read and upload the jar as if the url were a local path
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: