Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep same amount of partitions after repartitioning in IngestionJob #1279

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jan 20, 2021

Signed-off-by: Oleksii Moskalenko [email protected]

What this PR does / why we need it:

For streaming pipeline we don't need to create excessive amount of partitions.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
@pyalex
Copy link
Collaborator Author

pyalex commented Jan 20, 2021

/test test-end-to-end

Signed-off-by: Oleksii Moskalenko <[email protected]>
Copy link
Collaborator

@khorshuheng khorshuheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit cb3db2d into feast-dev:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants