Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable telemetry in docker-compose test and job_service #1297

Merged
merged 2 commits into from
Jan 28, 2021
Merged

disable telemetry in docker-compose test and job_service #1297

merged 2 commits into from
Jan 28, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 28, 2021

Signed-off-by: Jacob Klegar [email protected]

What this PR does / why we need it: disables telemetry in the docker-compose test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@jklegar
fix docker-compose test
598d147 
Signed-off-by: Jacob Klegar <[email protected]>
@jklegar
Copy link
Collaborator Author

jklegar commented Jan 28, 2021

/kind bug

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jan 28, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 28, 2021
@feast-ci-bot
Copy link
Collaborator

@jklegar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-gcp e94029a link /test test-end-to-end-gcp
test-end-to-end e94029a link /test test-end-to-end

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar jklegar changed the title disable telemetry in docker-compose test disable telemetry in docker-compose test and job_service Jan 28, 2021
@jklegar jklegar merged commit ac0f1df into feast-dev:master Jan 28, 2021
jklegar added a commit that referenced this pull request Jan 29, 2021
@jklegar
disable telemetry in docker-compose test and job_service (#1297)
ad47eda 
* fix docker-compose test

Signed-off-by: Jacob Klegar <[email protected]>

* disable telemetry in client that job_service uses

Signed-off-by: Jacob Klegar <[email protected]>
@jklegar jklegar deleted the jacob_fix_docker_test branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels
approved kind/bug release-note-none size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jklegar @feast-ci-bot @woop