Read and write path for Datastore and SQLite #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
reviewed
Mar 9, 2021
oavdeev
force-pushed
the
firebase-rw
branch
2 times, most recently
from
1860430
to
6bc92b9
Compare
Signed-off-by: Oleg Avdeev <[email protected]>
oavdeev
changed the title
|
/kind feature |
woop
reviewed
Mar 10, 2021
woop
reviewed
Mar 10, 2021
woop
reviewed
Mar 10, 2021
woop
reviewed
Mar 10, 2021
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
oavdeev
force-pushed
the
firebase-rw
branch
2 times, most recently
from
4674ec7
to
18a093f
Compare
Signed-off-by: Oleg Avdeev <[email protected]>
|
/retest |
|
/lgtm |
woop
approved these changes
Mar 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement read and write path for online store, both for local (SQLite) mode and GCP (Datastore).
It only implements a lower-level interface for reading and writing to be used internally in Feast, I expect we'll later have nicer wrappers over those methods in the SDK.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: