Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pulling query from BigQuery #1403

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Mar 22, 2021

What this PR does / why we need it: Add support to materialize a specified BigQuery query into the online store

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Adds support to materialize a specified BigQuery query into the online store

@jklegar
Copy link
Collaborator Author

jklegar commented Mar 22, 2021

Note this is stacked on #1379

@jklegar
Copy link
Collaborator Author

jklegar commented Mar 22, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Mar 22, 2021
@woop
Copy link
Member

woop commented Mar 23, 2021

@jklegar can you please rename test_bigquery_ingestion.py to test_materialize_from_bigquery_into_datastore.py or something?

Signed-off-by: Jacob Klegar <[email protected]>
Signed-off-by: Jacob Klegar <[email protected]>
@woop
Copy link
Member

woop commented Mar 24, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit f1e3072 into feast-dev:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants