Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate go #142

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Regenerate go #142

merged 2 commits into from
Feb 20, 2019

Conversation

zhilingc
Copy link
Collaborator

Update generated go protos.

@zhilingc
Copy link
Collaborator Author

/assign pradithya
/assign willem

@feast-ci-bot
Copy link
Collaborator

@zhilingc: GitHub didn't allow me to assign the following users: willem.

Note that only gojek members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign pradithya
/assign willem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradithya
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator Author

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 294a6ec into feast-dev:master Feb 20, 2019
@tims
Copy link
Contributor

tims commented Feb 20, 2019

Can we automate this in the build? We should never have to remember this

@tims
Copy link
Contributor

tims commented Feb 20, 2019

Eg for Go, we could make it regenerate the code and if it differs the merge should be aborted because of uncommitted changes

Python gen code should not be committed, it should be generated before we package wheels

@woop
Copy link
Member

woop commented Feb 23, 2019

Eg for Go, we could make it regenerate the code and if it differs the merge should be aborted because of uncommitted changes

Python gen code should not be committed, it should be generated before we package wheels

Does this require an issue in itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants