-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate go #142
Regenerate go #142
Conversation
/assign pradithya |
@zhilingc: GitHub didn't allow me to assign the following users: willem. Note that only gojek members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we automate this in the build? We should never have to remember this |
Eg for Go, we could make it regenerate the code and if it differs the merge should be aborted because of uncommitted changes Python gen code should not be committed, it should be generated before we package wheels |
Does this require an issue in itself? |
Update generated go protos.