Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add materialize-incremental cli test #1445

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Apr 8, 2021

What this PR does / why we need it: We add a unit test for feast materialize-incremental cli command to make sure it doesn't silently break in future.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 8, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit ba98c8a into master Apr 8, 2021
@woop woop deleted the materialize-incremental-test branch May 12, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants