Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate datetimes in materialize in correct order #1456

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Validate datetimes in materialize in correct order #1456

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76c2430
Validate datetimes in materialize in correct order
jklegar Apr 12, 2021
6ce776e
make tzaware
jklegar Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,11 @@ def materialize(
"""
self._tele.log("materialize")

if start_date > end_date:
raise ValueError(
f"The given start_date {start_date} is greater than the given end_date {end_date}."
)

feature_views_to_materialize = []
if feature_views is None:
feature_views_to_materialize = self._registry.list_feature_views(
Expand Down