Optimize write rate in Gcp Firestore #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsotnet
force-pushed
the
optimize-firestore-writes
branch
2 times, most recently
from
10e14c9
to
685b501
Compare
tsotnet
force-pushed
the
optimize-firestore-writes
branch
2 times, most recently
from
1f2f5a4
to
1263873
Compare
woop
reviewed
Apr 12, 2021
woop
reviewed
Apr 12, 2021
tsotnet
force-pushed
the
optimize-firestore-writes
branch
from
1263873
to
2d38946
Compare
Signed-off-by: Tsotne Tabidze <[email protected]>
tsotnet
force-pushed
the
optimize-firestore-writes
branch
from
2d38946
to
eec8f5b
Compare
|
/test test-telemetry |
|
/lgtm |
woop
approved these changes
Apr 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: We used to have less than 100 QPS on writing data to the online store in Gcp Firestore. This was due to using non-batch requests (get & put) instead of batch variants (get_multi & put_multi). Moreover, we completely removed the read part of the functionality and directly write the new data without comparing timestamps. So, it's up to the user now to make sure they're not overwriting old data over the new data. In future we'll add a flag that if enabled by the user, will do this check on every write, but the performance hit is too much to leave it on by default.
The new functionality benchmarks at ~1.95K writes per second.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: