Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper template generation to Feast CLI #1460

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

woop
Copy link
Member

@woop woop commented Apr 13, 2021

What this PR does / why we need it:

  • Adds proper templating to Feast. Instead of writing repos from inline yaml/code, we now store the templates under sdk/python/feast/templates.
  • Templates can be initialized using feast init -t template_name, e.g, feast init -t gcp
  • We have templates for local, gcp, and minimal.
  • The gcp template is newly added.
  • The default template is local. Meaning feast init will use the local template.
  • The minimal template can also be selected using feast init --minimal, which creates a nearly empty repository.

Does this PR introduce a user-facing change?:

Templating added to Feast init command

Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator

jklegar commented Apr 13, 2021

/lgtm

@woop woop added the kind/feature New feature or request label Apr 13, 2021
@feast-ci-bot feast-ci-bot merged commit 1655b79 into feast-dev:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants