Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary MAVEN_CONFIG #1472

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

danielsiwiec
Copy link
Contributor

@danielsiwiec danielsiwiec commented Apr 15, 2021

Remove unused environment variable. The MAVEN_CONFIG variable is used by the maven Docker image (which we're not using) and is not used by Maven itself in any way. It is colliding with Maven Wrapper configuration (which also uses this variable) and is causing feast-dev/feast-java-old#26 to fail

@feast-ci-bot
Copy link
Collaborator

Hi @danielsiwiec. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielsiwiec
Copy link
Contributor Author

/assign @woop

@woop
Copy link
Member

woop commented Apr 15, 2021

/ok-to-test

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielsiwiec, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 19, 2021

/lgtm

@woop
Copy link
Member

woop commented Apr 19, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit a0fa357 into feast-dev:master Apr 19, 2021
@danielsiwiec danielsiwiec deleted the mvn-config branch April 19, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants