-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unix Timestamp value type #1520
Add Unix Timestamp value type #1520
Conversation
Hi @MattDelac. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
7568841
to
0bbe997
Compare
/kind feature |
Hey @MattDelac, thanks for the contribution! Overall it looks good to me. One thing that is a glaring omissions (not with your PR but with our code) is that we're not testing all the different types. Regardless, we can add that test a bit later. I've added a note to add a test here. I think the only thing missing here is an update to our documentation. You may need to update the specs to document the new type: https://github.com/feast-dev/feast/tree/master/docs/specs |
Yes that was my surprise that none of the tests had to be changed
Sounds good. I let you fix it later 👌
Good catch ! Will look into the doc |
a89bff6
to
c98dd86
Compare
Done. The docs are now up to date. Let me know if I missed another one. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MattDelac, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matt Delacour <[email protected]>
Signed-off-by: Matt Delacour <[email protected]>
Signed-off-by: Matt Delacour <[email protected]>
c4c49c0
to
48f31d0
Compare
/lgtm |
@MattDelac: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
* Add Unix Timestamp value type Signed-off-by: Matt Delacour <[email protected]> * Update docs Signed-off-by: Matt Delacour <[email protected]> * Handle Scalar type Signed-off-by: Matt Delacour <[email protected]>
* Add Unix Timestamp value type Signed-off-by: Matt Delacour <[email protected]> * Update docs Signed-off-by: Matt Delacour <[email protected]> * Handle Scalar type Signed-off-by: Matt Delacour <[email protected]>
What this PR does / why we need it:
As discussed in Slack, so far, we don't want to support datetime dtypes in general. Therefore, so far we would need to convert any datetime data types into a unix timestamp and store it as an INT in feast.
While converting in unix timestamp is not an issue, it makes it hard to differentiate the features that are int vs timestamp when looking at a FeatureView
Thus this PR aims to introduce a new datatype "Unix Timestamp" that beyond the scene would be an INT. For the end user, this will make it easier understand a FeatureView.
It also add a potential possibility to do things differently with Unix Timestamp features at retrieval time.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: