Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastore namespace option in configs #1581

Merged
merged 1 commit into from
May 24, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented May 24, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: Feast gcp provider used default namespace for all its operations. Here we add a new config in feature_store.yaml that overrides the namespace. For example:

project: my_repo
registry: data/registry.db
provider: gcp
online_store:
  type: datastore
  namespace: foo

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add `online_store->namespace` field in `feature_store.yaml` that overrides datastore namespace that gcp provider uses

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1581 (c179f88) into master (6e243b8) will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
+ Coverage   83.55%   83.59%   +0.03%     
==========================================
  Files          65       65              
  Lines        5752     5753       +1     
==========================================
+ Hits         4806     4809       +3     
+ Misses        946      944       -2     
Flag Coverage Δ
integrationtests 83.50% <88.88%> (+<0.01%) ⬆️
unittests 77.36% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 95.28% <66.66%> (+0.04%) ⬆️
sdk/python/feast/infra/gcp.py 83.87% <100.00%> (+1.61%) ⬆️
...hon/tests/test_offline_online_store_consistency.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e243b8...c179f88. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented May 24, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit dfb029d into feast-dev:master May 24, 2021
jklegar pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants