-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a specific error for missing columns during materialization #1619
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 77.61% 77.63% +0.02%
==========================================
Files 66 66
Lines 5789 5799 +10
==========================================
+ Hits 4493 4502 +9
- Misses 1296 1297 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8db43cb
to
26c4aa6
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
859c842
to
751eeb1
Compare
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
2ff2504
to
44b07eb
Compare
@woop ready for re-review |
/lgtm |
@woop for some reason this didn't get auto-merged - can you approve if it looks okay? |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Follow up from #1615 based on the comment in #1614 . Also adds test and removed an empty file.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: