Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an OnlineStore interface #1628

Merged
merged 13 commits into from
Jun 11, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jun 8, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:
Similar to how we decoupled the the OfflineStore for extensibility, this PR pulls out the OnlineStore. It also updates tests, and refactors the Sqlite implementation and GCP into their own components.

Which issue(s) this PR fixes:

Fixes #1573

Does this PR introduce a user-facing change?:

Introduce an OnlineStore interface.

@feast-ci-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Achal Shah <[email protected]>
@achals achals force-pushed the achal/online-store-interface branch from d61b927 to 136c1dc Compare June 10, 2021 00:38
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@achals achals marked this pull request as ready for review June 10, 2021 16:32
@achals achals requested review from tsotnet, woop and a team as code owners June 10, 2021 16:32
…d invoke it from the providers

Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #1628 (6367767) into master (0d7e858) will decrease coverage by 0.01%.
The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   83.59%   83.58%   -0.02%     
==========================================
  Files          67       71       +4     
  Lines        6017     6104      +87     
==========================================
+ Hits         5030     5102      +72     
- Misses        987     1002      +15     
Flag Coverage Δ
integrationtests 83.50% <86.79%> (-0.02%) ⬇️
unittests 76.38% <82.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 92.95% <ø> (ø)
sdk/python/tests/online_read_write_test.py 100.00% <ø> (ø)
sdk/python/tests/test_cli_redis.py 100.00% <ø> (ø)
...hon/tests/test_offline_online_store_consistency.py 100.00% <ø> (ø)
sdk/python/tests/test_online_retrieval.py 100.00% <ø> (ø)
sdk/python/feast/errors.py 65.85% <66.66%> (+0.06%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 79.09% <79.09%> (ø)
sdk/python/feast/infra/online_stores/helpers.py 79.41% <79.41%> (ø)
...k/python/feast/infra/online_stores/online_store.py 80.95% <80.95%> (ø)
sdk/python/feast/infra/local.py 90.00% <88.88%> (-6.74%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7e858...6367767. Read the comment docs.

Signed-off-by: Achal Shah <[email protected]>
@achals achals requested a review from woop June 11, 2021 16:11
@achals achals added the kind/feature New feature or request label Jun 11, 2021
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 11, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit c63b037 into feast-dev:master Jun 11, 2021
@achals achals deleted the achal/online-store-interface branch June 11, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Online Store from Provider
4 participants