-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an OnlineStore interface #1628
Introduce an OnlineStore interface #1628
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
d61b927
to
136c1dc
Compare
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
…d invoke it from the providers Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 83.59% 83.58% -0.02%
==========================================
Files 67 71 +4
Lines 6017 6104 +87
==========================================
+ Hits 5030 5102 +72
- Misses 987 1002 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ections Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Similar to how we decoupled the the OfflineStore for extensibility, this PR pulls out the OnlineStore. It also updates tests, and refactors the Sqlite implementation and GCP into their own components.
Which issue(s) this PR fixes:
Fixes #1573
Does this PR introduce a user-facing change?: