Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS authentication using github actions #1629

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Jun 8, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: Adds authenticating in Feast's AWS account using Github actions. This will unlock integration tests using S3, Dynamo, Redshift.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #1629 (a083508) into master (62f826b) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
+ Coverage   83.59%   83.86%   +0.27%     
==========================================
  Files          65       67       +2     
  Lines        5755     5883     +128     
==========================================
+ Hits         4811     4934     +123     
- Misses        944      949       +5     
Flag Coverage Δ
integrationtests 83.80% <ø> (+0.26%) ⬆️
unittests 77.62% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/conftest.py 96.77% <0.00%> (-3.23%) ⬇️
sdk/python/feast/telemetry.py 61.53% <0.00%> (-1.09%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 96.66% <0.00%> (-1.07%) ⬇️
sdk/python/feast/infra/gcp.py 83.60% <0.00%> (-0.27%) ⬇️
sdk/python/feast/infra/local.py 96.73% <0.00%> (-0.14%) ⬇️
sdk/python/feast/data_source.py 78.77% <0.00%> (-0.07%) ⬇️
sdk/python/tests/test_feature_store.py 100.00% <0.00%> (ø)
...dk/python/tensorflow_metadata/proto/v0/path_pb2.py 100.00% <0.00%> (ø)
.../python/tensorflow_metadata/proto/v0/schema_pb2.py 100.00% <0.00%> (ø)
...hon/tensorflow_metadata/proto/v0/statistics_pb2.py 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f826b...a083508. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 8, 2021

/lgtm

@woop woop merged commit f270566 into feast-dev:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants