Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OfflineStoreConfig classes into their owning modules #1657

Merged
merged 7 commits into from
Jun 22, 2021
Merged

Refactor OfflineStoreConfig classes into their owning modules #1657

merged 7 commits into from
Jun 22, 2021

Commits on Jun 21, 2021

  1. Refactor OfflineStoreConfig classes into their owning modules 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c642b42 View commit details
    Browse the repository at this point in the history

  2. Fix error string 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ec876d6 View commit details
    Browse the repository at this point in the history

  3. Generic error class 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2030e47 View commit details
    Browse the repository at this point in the history

  4. Merge conflicts 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c94ae83 View commit details
    Browse the repository at this point in the history

  5. make the store type work, and add a test that uses the fully qualifie… 

    …d name of the OnlineStore

Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    fa5f912 View commit details
    Browse the repository at this point in the history

  6. Address comments from previous PR 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0b3d14c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. CR updates 

    Signed-off-by: Achal Shah <[email protected]>
    @achals
    achals committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    df59a5d View commit details
    Browse the repository at this point in the history