-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement materialization for RedshiftOfflineStore & RedshiftRetrievalJob #1680
Implement materialization for RedshiftOfflineStore & RedshiftRetrievalJob #1680
Conversation
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
===========================================
- Coverage 82.75% 69.10% -13.65%
===========================================
Files 76 76
Lines 6754 6817 +63
===========================================
- Hits 5589 4711 -878
- Misses 1165 2106 +941
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…lJob (feast-dev#1680) * Implement materialization for RedshiftOfflineStore Signed-off-by: Tsotne Tabidze <[email protected]> * Address Willem's comments Signed-off-by: Tsotne Tabidze <[email protected]> * Rename method Signed-off-by: Tsotne Tabidze <[email protected]> Signed-off-by: CS <[email protected]>
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: This PR makes it possible to materialize data from Redshift to online stores. Also added half of test_offline_online_store_consistency.py for Redshift (for now we're only asserting online store after materialization from Redshift and don't check offline store by calling get_historical_features, since that functionality is not yet implemented). This required implementing unload/copy logic through S3. RedshiftRetrievalJob is also fully implemented (to_df, to_arrow, to_s3, to_redshift).
Lastly, needed to add
iam_role
to the redshift config. This role is necessary for Redshift to access S3. It'll need to be setup by the user (both the role creation, and association to Redshift).Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: