Fix dry_run bug that was making to_bigquery hang indefinitely

[codyjlin]

Signed-off-by: Cody Lin [email protected]

What this PR does / why we need it:
In PR #1661, I accidentally switched the order of the dry_run output and _block_until_done (these lines) in BigQueryRetrievalJob.to_bigquery that was making any dry_run call to hang. I fix it here.

Which issue(s) this PR fixes:

(Not large enough for issue)

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codyjlin]

/kind bug

[codecov-commenter]

Codecov Report

Merging #1706 (f23b4fc) into master (0d2179d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          76       76           
  Lines        6754     6754           
=======================================
  Hits         5589     5589           
  Misses       1165     1165           

Flag	Coverage Δ
integrationtests	82.67% <0.00%> (ø)
unittests	69.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py	76.14% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2179d...f23b4fc. Read the comment docs.

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment