Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS documentation (DynamoDB, Redshift) #1733

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Jul 23, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Document AWS Provider (including DynamoDB & Redshift)

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #1733 (8a0937d) into master (bf557bc) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   79.06%   78.45%   -0.61%     
==========================================
  Files          80       80              
  Lines        6849     7046     +197     
==========================================
+ Hits         5415     5528     +113     
- Misses       1434     1518      +84     
Flag Coverage Δ
integrationtests 79.00% <ø> (+0.01%) ⬆️
unittests 61.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gration/offline_store/test_historical_retrieval.py 80.54% <0.00%> (-18.40%) ⬇️
...n/tests/integration/registration/test_inference.py 84.44% <0.00%> (-15.56%) ⬇️
sdk/python/feast/feature_view.py 88.54% <0.00%> (-0.44%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 97.14% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf557bc...8a0937d. Read the comment docs.

@woop
Copy link
Member

woop commented Jul 27, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jul 27, 2021

Assuming TODOs will come in another PR.

@feast-ci-bot feast-ci-bot merged commit 9ae9e3c into feast-dev:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants