-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teardown integration tests resources for aws #1740
Teardown integration tests resources for aws #1740
Conversation
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
===========================================
+ Coverage 61.75% 79.07% +17.31%
===========================================
Files 78 80 +2
Lines 6759 6852 +93
===========================================
+ Hits 4174 5418 +1244
+ Misses 2585 1434 -1151
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
Should be we be making this change for all calls to |
Yes - this may be solved by the integration test refactor but I'm making the change here becuase it's causing us to blow past our Dynamodb limit. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Similar to #1697.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: