Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teardown integration tests resources for aws #1740

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jul 27, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Similar to #1697.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #1740 (f4116bf) into master (b1cbf20) will increase coverage by 17.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1740       +/-   ##
===========================================
+ Coverage   61.75%   79.07%   +17.31%     
===========================================
  Files          78       80        +2     
  Lines        6759     6852       +93     
===========================================
+ Hits         4174     5418     +1244     
+ Misses       2585     1434     -1151     
Flag Coverage Δ
integrationtests 78.99% <100.00%> (?)
unittests 61.72% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gration/offline_store/test_historical_retrieval.py 98.95% <100.00%> (+48.78%) ⬆️
sdk/python/feast/infra/aws.py 100.00% <0.00%> (ø)
sdk/python/feast/infra/gcp.py 100.00% <0.00%> (ø)
sdk/python/feast/data_source.py 56.19% <0.00%> (+0.47%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 97.59% <0.00%> (+1.20%) ⬆️
sdk/python/feast/feature_store.py 93.50% <0.00%> (+2.16%) ⬆️
sdk/python/tests/conftest.py 100.00% <0.00%> (+3.22%) ⬆️
sdk/python/feast/repo_config.py 94.26% <0.00%> (+4.09%) ⬆️
sdk/python/feast/errors.py 70.52% <0.00%> (+4.21%) ⬆️
sdk/python/feast/infra/provider.py 89.09% <0.00%> (+4.54%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cbf20...f4116bf. Read the comment docs.

Signed-off-by: Achal Shah <[email protected]>
@felixwang9817
Copy link
Collaborator

Should be we be making this change for all calls to fs.teardown() in our integration tests? There are a bunch of other places we teardown: test_feature_store, test_registry (for registry teardown), etc.

@achals
Copy link
Member Author

achals commented Jul 27, 2021

Should be we be making this change for all calls to fs.teardown() in our integration tests? There are a bunch of other places we teardown: test_feature_store, test_registry (for registry teardown), etc.

Yes - this may be solved by the integration test refactor but I'm making the change here becuase it's causing us to blow past our Dynamodb limit.

@felixwang9817
Copy link
Collaborator

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 47f30b3 into feast-dev:master Jul 27, 2021
@achals achals deleted the achal/teardown-integration-test branch July 27, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants