Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old code #1743

Merged
merged 5 commits into from
Jul 29, 2021
Merged

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR deletes old code left over from previous Feast versions (Client, grpc, etc.).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Deletes Client

Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #1743 (6c94654) into master (2dfdace) will increase coverage by 4.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
+ Coverage   79.10%   83.97%   +4.87%     
==========================================
  Files          81       73       -8     
  Lines        6938     5996     -942     
==========================================
- Hits         5488     5035     -453     
+ Misses       1450      961     -489     
Flag Coverage Δ
integrationtests 83.88% <ø> (+4.86%) ⬆️
unittests 64.15% <ø> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/__init__.py 90.00% <ø> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfdace...6c94654. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

/retest

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 6b9a79b into feast-dev:master Jul 29, 2021
@felixwang9817 felixwang9817 deleted the delete_old_code branch July 29, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants