Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document permissions for AWS (DynamoDB & Redshift) #1753

Merged

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Aug 1, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: This PR documents necessary permissions for DynamoDB & Redshift (including the Redshift IAM role for accessing S3).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Document permissions for AWS (DynamoDB & Redshift)

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021

Codecov Report

Merging #1753 (b7d8baa) into master (651d066) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1753   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files          73       73           
  Lines        6003     6003           
=======================================
  Hits         5039     5039           
  Misses        964      964           
Flag Coverage Δ
integrationtests 83.85% <ø> (ø)
unittests 64.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651d066...b7d8baa. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8f6e8df into feast-dev:master Aug 1, 2021
@woop
Copy link
Member

woop commented Aug 4, 2021

Nice job @tsotnet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants