Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docstring tests #1778

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: The current docstring tests in FeatureStore are a bit verbose. This PR makes them more concise by moving most of the setup logic into a setup function.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #1778 (78fe198) into master (8ef2053) will decrease coverage by 1.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   84.71%   83.41%   -1.31%     
==========================================
  Files          86       87       +1     
  Lines        6308     6776     +468     
==========================================
+ Hits         5344     5652     +308     
- Misses        964     1124     +160     
Flag Coverage Δ
integrationtests 85.12% <100.00%> (+0.46%) ⬆️
unittests 64.34% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 92.90% <ø> (-0.68%) ⬇️
sdk/python/tests/doctest/test_all.py 95.91% <100.00%> (+0.79%) ⬆️
...python/tests/integration/e2e/test_universal_e2e.py 60.60% <0.00%> (-24.76%) ⬇️
...gration/offline_store/test_historical_retrieval.py 79.51% <0.00%> (-19.55%) ⬇️
...alization/test_offline_online_store_consistency.py 82.75% <0.00%> (-17.25%) ⬇️
...tegration/feature_repos/test_repo_configuration.py 94.77% <0.00%> (-5.23%) ⬇️
sdk/python/feast/feature_view.py 87.05% <0.00%> (-0.72%) ⬇️
...ts/integration/feature_repos/universal/entities.py 100.00% <0.00%> (ø)
...tegration/feature_repos/universal/feature_views.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef2053...78fe198. Read the comment docs.

@woop
Copy link
Member

woop commented Aug 11, 2021

This is awesome :)

Signed-off-by: Felix Wang <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit 74c7bed into feast-dev:master Aug 16, 2021
@felixwang9817 felixwang9817 deleted the doctest_cleanup branch August 16, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants