-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up docstring tests #1778
Clean up docstring tests #1778
Conversation
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
- Coverage 84.71% 83.41% -1.31%
==========================================
Files 86 87 +1
Lines 6308 6776 +468
==========================================
+ Hits 5344 5652 +308
- Misses 964 1124 +160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is awesome :) |
Signed-off-by: Felix Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind housekeeping |
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: The current docstring tests in FeatureStore are a bit verbose. This PR makes them more concise by moving most of the setup logic into a setup function.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: