-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_online_features telemetry to only log every 10000 times #1786
Conversation
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
==========================================
- Coverage 85.37% 85.35% -0.02%
==========================================
Files 88 88
Lines 6583 6584 +1
==========================================
Hits 5620 5620
- Misses 963 964 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind bug |
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Fix get_online_features telemetry to only log every 10000 times Signed-off-by: Felix Wang <[email protected]> * Avoid int overflow Signed-off-by: Felix Wang <[email protected]> * Log telemetry on second but not first call Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: Telemetry for
get_online_features
currently has a bug where telemetry is being logged during every call toget_online_features
, instead of every 10000 calls. This PR fixes that bug.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: