Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_online_features telemetry to only log every 10000 times #1786

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: Telemetry for get_online_features currently has a bug where telemetry is being logged during every call to get_online_features, instead of every 10000 calls. This PR fixes that bug.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1786 (c40c8e6) into master (da436b5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
- Coverage   85.37%   85.35%   -0.02%     
==========================================
  Files          88       88              
  Lines        6583     6584       +1     
==========================================
  Hits         5620     5620              
- Misses        963      964       +1     
Flag Coverage Δ
integrationtests 85.28% <0.00%> (-0.02%) ⬇️
unittests 63.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/usage.py 60.95% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da436b5...c40c8e6. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

/kind bug

sdk/python/feast/usage.py Show resolved Hide resolved
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 18, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7ef5a41 into feast-dev:master Aug 18, 2021
@felixwang9817 felixwang9817 deleted the telemetry branch August 18, 2021 18:06
woop pushed a commit that referenced this pull request Aug 20, 2021
* Fix get_online_features telemetry to only log every 10000 times

Signed-off-by: Felix Wang <[email protected]>

* Avoid int overflow

Signed-off-by: Felix Wang <[email protected]>

* Log telemetry on second but not first call

Signed-off-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants