Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a random dataset and table name for simple_bq_source #1801

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

achals
Copy link
Member

@achals achals commented Aug 25, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1760

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #1801 (6a66c0f) into master (6aa9342) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
+ Coverage   84.80%   84.85%   +0.04%     
==========================================
  Files          92       92              
  Lines        6826     6828       +2     
==========================================
+ Hits         5789     5794       +5     
+ Misses       1037     1034       -3     
Flag Coverage Δ
integrationtests 84.78% <100.00%> (+0.02%) ⬆️
unittests 63.94% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/data_source_utils.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/online_stores/datastore.py 93.10% <0.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa9342...6a66c0f. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 25, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit db6df04 into feast-dev:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BigQuery related integration tests to make unique BQ datasets and tables
4 participants