Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old doc #1815

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Remove old doc #1815

merged 1 commit into from
Aug 31, 2021

Conversation

achals
Copy link
Member

@achals achals commented Aug 30, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:
This has been superceded by the docs describing how to add online and offline stores.
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 45766de into feast-dev:master Aug 31, 2021
@achals achals deleted the achal/kill-old-dox branch August 31, 2021 05:42
adchia pushed a commit to adchia/feast that referenced this pull request Sep 1, 2021
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
woop added a commit that referenced this pull request Sep 1, 2021
* Add quickstart to examples folder

Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>

* Add message about restarting the Jupyter runtime to Quickstart

Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 12 pages and 5 assets modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] one page modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 2 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 47 pages and one asset modified

Signed-off-by: Danny Chiao <[email protected]>

* Updating quickstart colab to explain more concepts and highlight value prop of Feast (#1799)

* Updating quickstart colab to explain more concepts and highlight value prop of Feast

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 2 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 3 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 58 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 2 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] one page modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 61 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 2 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] one page modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 3 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* kill old doc (#1815)

Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 62 pages modified

Signed-off-by: Danny Chiao <[email protected]>

* GitBook: [master] 2 pages modified

Signed-off-by: Danny Chiao <[email protected]>

Co-authored-by: Willem Pienaar <[email protected]>
Co-authored-by: Willem Pienaar <[email protected]>
Co-authored-by: Achal Shah <[email protected]>
Co-authored-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants